Skip to content

Commit e551790

Browse files
committed
Add max value size limit to status page
1 parent af26fb1 commit e551790

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

  • runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state

runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillStateCache.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,11 @@ public void setMaxCachedValueBytesOverride(long limit) {
126126
this.maxCachedValueBytesOverride = limit;
127127
}
128128

129+
private long getMaxCachedValueBytesLimit() {
130+
long override = maxCachedValueBytesOverride;
131+
return override >= 0 ? override : defaultMaxCachedValueBytes;
132+
}
133+
129134
private EntryStats calculateEntryStats() {
130135
EntryStats stats = new EntryStats();
131136
BiConsumer<StateId, StateCacheEntry> consumer =
@@ -204,6 +209,8 @@ public void appendSummaryHtml(PrintWriter response) {
204209
"<tr><th>Entry Weight</th><td>" + entryStats.entryWeight / MEGABYTES + "MB</td></tr>");
205210
response.println("<tr><th>Max Weight</th><td>" + getMaxWeight() / MEGABYTES + "MB</td></tr>");
206211
response.println("<tr><th>Keys</th><td>" + keyIndex.size() + "</td></tr>");
212+
response.println(
213+
"<tr><th>Value Size Limit</th><td>" + getMaxCachedValueBytesLimit() + " bytes</td></tr>");
207214
if (enableHistogram) {
208215
response.println(
209216
"<tr><th>Entry Weight Dist</th><td>"
@@ -499,8 +506,7 @@ public <T extends State> void put(
499506
}
500507

501508
public void persist() {
502-
long override = WindmillStateCache.this.maxCachedValueBytesOverride;
503-
long limit = override >= 0 ? override : WindmillStateCache.this.defaultMaxCachedValueBytes;
509+
long limit = WindmillStateCache.this.getMaxCachedValueBytesLimit();
504510
localCache.forEach(
505511
(id, entry) -> {
506512
if (entry.getWeight() <= limit) {

0 commit comments

Comments
 (0)