Fix duplicate build for build rc wheel GitHub Action #27370
Conversation
* Fix source release file names * Avoid duplicate run of build wheels for rc
Codecov Report
@@ Coverage Diff @@
## master #27370 +/- ##
==========================================
+ Coverage 71.24% 71.26% +0.01%
==========================================
Files 854 854
Lines 103716 103736 +20
==========================================
+ Hits 73892 73925 +33
+ Misses 28277 28264 -13
Partials 1547 1547
Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| @@ -109,7 +109,7 @@ jobs: | |||
| RC_ZIP="${RC_DIR}.zip" | |||
| RELEASE_DIR="beam-${{ github.event.inputs.RELEASE }}" | |||
| RC_TAG="v${{ github.event.inputs.RELEASE }}-RC${{ github.event.inputs.RC }}" | |||
| SOURCE_RELEASE_ZIP="apache-beam-${RELEASE}-source-release.zip" | |||
| SOURCE_RELEASE_ZIP="apache-beam-${{ github.event.inputs.RELEASE }}-source-release.zip" | |||
There was a problem hiding this comment.
otherwise the name appears to be apache-beam--source-release.zip (should be apache-beam-2.49.0-source-release.zip) see https://dist.apache.org/repos/dist/dev/beam/2.49.0/
| @@ -23,7 +23,6 @@ | |||
| import logging | |||
| import unittest | |||
| from collections import namedtuple | |||
| from typing import Any | |||
There was a problem hiding this comment.
this change (minor internal pylint fix) makes the affected action to trigger: see a run on fork repo: https://github.com/Abacn/beam/actions/runs/5469847290/jobs/9959265164
|
convert to draft for now; will mark as ready to review when release finish |
|
Reminder, please take a look at this pr: @AnandInguva @damccorm |
Fixes #27368
Fix source release file names
Avoid duplicate run of build wheels for rc
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.