Auto-enable allowDuplicates for Redistribute with ALO streaming mode#34490
Merged
johnjcasey merged 5 commits intoapache:masterfrom Apr 4, 2025
Merged
Auto-enable allowDuplicates for Redistribute with ALO streaming mode#34490johnjcasey merged 5 commits intoapache:masterfrom
johnjcasey merged 5 commits intoapache:masterfrom
Conversation
…owDuplicates for Redistribtue
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @johnjcasey added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
R: @Naireen |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Contributor
|
Just need some testing, look here for some pointers: |
Contributor
|
LGTM |
Contributor
Author
|
R: @johnjcasey, hi, would you mind helping merge this? Thanks! |
liferoad
pushed a commit
to liferoad/beam
that referenced
this pull request
Apr 4, 2025
…pache#34490) * Extrac streaming mode from pipeline options and use it to turn on allowDuplicates for Redistribtue * Fix format * Add test. * Fix test failure and formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract streaming mode from pipeline options, make the resulting Redistribute transform allow duplicates if either the original Redistribute allows duplicates or streaming mode is At-Least-Once.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.