-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade sidepanel extension to JupyterLab 4.x compatibility [DO NOT MERGE] #34495
base: master
Are you sure you want to change the base?
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Does this still work with 3.x? we will need to release this later as well. |
I build it with 3.x and it failed. Because the version of |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looks like this is causing precommit failures, could you please take a look? https://github.com/apache/beam/actions/runs/14197749402/job/39777121469
Do not merge this PR. Please wait for me to LGTM. |
The testsuites and CI scripts are also needed to be upgrade. I'll commit my changes later this day. |
@@ -67,7 +67,7 @@ | |||
|
|||
## New Features / Improvements | |||
|
|||
* X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)). | |||
* Python: Added JupyterLab 4.x extension compatibility for enhanced notebook integration ([#34495](https://github.com/apache/beam/pull/34495)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also a breaking change if we require 4.x now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! I'm not rushing for this PR to be merged—just checking in to make sure it wasn't forgotten."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 21 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (2)
- .github/gh-actions-self-hosted-runners/arc/images/Dockerfile: Language not supported
- sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/package.json: Language not supported
Comments suppressed due to low confidence (2)
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts:67
- [nitpick] Consider renaming 'firstModel' to a more descriptive name (e.g. 'initialSessionModel') to clarify that it represents the first session model returned by the iterator.
if (sessionModel.value.kernel.id !== firstModel.value.kernel.id) {
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/tests/inspector/InteractiveInspector.test.tsx:191
- [nitpick] Consider replacing arbitrary setTimeout delays with waitFor from @testing-library/react to better handle asynchronous updates and improve test reliability.
await new Promise(resolve => setTimeout(resolve, 100));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nika-qubit can you share the steps to build a new release? I want to test this internally first. |
Updated all
@jupyterlab/*
dependencies to v4.xAdapted to breaking API changes (SessionContext, TypeScript types, etc.)
Fixed strict type checking errors introduced in TS 4.x
Requires Node 16+ and updated dependencies
Upgrade to React 18+
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.