Skip to content

Python PTransform wrapper for AWS SQS #34581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

prodriguezdefino
Copy link
Contributor

@prodriguezdefino prodriguezdefino commented Apr 8, 2025

Completes the work started on #34327 to expose the SQS read functionality to the Python SDK.

Added integration tests for the Direct Runner executed as part of a post commit suite. Tested execution of the new GitHub workflow in the forked repository, see link.


GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@prodriguezdefino
Copy link
Contributor Author

fixes #34326

@github-actions github-actions bot added the build label Apr 9, 2025
@prodriguezdefino prodriguezdefino marked this pull request as ready for review April 11, 2025 01:34
"""
URN = "beam:schematransform:org.apache.beam:aws:sqs_read:v1"

def __init__(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(question to @ahmedabu98) Shall we add this external transform to auto wrapper?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks like something that can be automated using standard_expansion_services.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the integration test below can dynamically generate and use the transform with ExternalTransformProvider

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question, can the integration test use the newly generated transform instead of the ExternalTransformProvider? given the dependencies the new Python wrapper should already be in place, is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I made the changes to make the IT use the ExternalTransformProvider. Thanks for for the pointers.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @ahmedabu98 for label java.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants