Add adapters to address output conversion for OfflineDetector. #34662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunping
force-pushed
the
anomaly-better-model-output-type
branch
from
7bf6a54 to
979fa37
Compare
shunping
force-pushed
the
anomaly-better-model-output-type
branch
from
10cb58b to
6525546
Compare
|
The failed coverage tests are unrelated to this PR. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
damccorm
reviewed
Apr 18, 2025
| assert isinstance(prediction, AnomalyPrediction), ( | ||
| "Wrong model handler output type." + | ||
| f"Expected: 'AnomalyPrediction', but got '{type(prediction).__name__}'. " + # pylint: disable=line-too-long | ||
| "Consider adding a post-processing function via `with_postprocess_fn`.") |
There was a problem hiding this comment.
Suggested change
| "Consider adding a post-processing function via `with_postprocess_fn`.") | |
| "Consider adding a post-processing function via `with_postprocess_fn`" + | |
| "to convert from '{type(prediction).__name__}' to 'AnomalyPrediction', or " + | |
| "use `score_prediction_adapter` or `label_prediction_adapter` to " + | |
| "perform the conversion.") |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
OfflineDetectorassumed that user-provided model handlers would output floating-point score values. This assumption often doesn't hold, particularly for third-party anomaly detection models (like PyOD's) that output labels instead of scores.This PR addresses this by making the output type generic (using a type variable). It also introduces common adapters to convert
RunInferencepredictions into theAnomalyPredictionformat. This approach improves ease-of-use for common scenarios while preserving flexibility for future extensions.