Skip to content

Conversation

@damccorm
Copy link
Contributor

#37305 didn't accomplish its goal since the version of spanner could still be picked up by the gcp bom. This should fix the problem (I was able to verify this by publishing to my local maven and using that)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Jan 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical dependency versioning issue within the Apache Beam GCP Bill of Materials (BOM). By explicitly declaring the Google Cloud Spanner BOM and subsequently excluding Spanner-related modules from the broader GCP BOM, the change ensures that a specific, older version of Spanner is consistently used. This approach resolves a problem where previous attempts to manage Spanner versions were overridden by the GCP BOM, leading to unintended upgrades and potential instability. The current implementation is noted as a temporary workaround until upstream issues or tests are resolved.

Highlights

  • Pinning Spanner Version: The pull request explicitly pins the version of Google Cloud Spanner by importing its Bill of Materials (BOM) separately within the GCP BOM.
  • Excluding Conflicting Modules: To prevent version conflicts, several specific Spanner-related modules are now explicitly excluded from the general Google Cloud Platform libraries BOM.
  • Addressing Previous Issue: This change is a follow-up to a previous attempt (PR Revert spanner version #37305) that failed to correctly control Spanner versions, aiming to provide a definitive fix for the versioning problem.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@damccorm
Copy link
Contributor Author

R: @Abacn

I plan to merge this and #37327 and cherry-pick both before building the new RC.

I think either should fix the problem, but this seems like the safest route for fixing the problem broadly, and I confirmed that it works

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm damccorm merged commit 82ebcb2 into master Jan 16, 2026
18 checks passed
@damccorm damccorm deleted the users/damccorm/pinSpanner branch January 16, 2026 18:13
damccorm added a commit that referenced this pull request Jan 16, 2026
@damccorm damccorm mentioned this pull request Jan 16, 2026
3 tasks
damccorm added a commit that referenced this pull request Jan 16, 2026
* Pin spanner to old version in gcp bom (#37329)

* Fix spanner io hang by closing connections (#37327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants