Skip to content

Commit 5b3cd8d

Browse files
authored
build: remove empty module backward-compat yahoo-custom-version (#4331)
### Changes 1. Remove empty module backward-compat yahoo-custom-version 2. fix a minor annotation in LedgerHandle Signed-off-by: ZhangJian He <[email protected]>
1 parent 163046a commit 5b3cd8d

File tree

4 files changed

+2
-35
lines changed

4 files changed

+2
-35
lines changed

.github/workflows/bk-ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ jobs:
329329

330330
- name: Other tests
331331
run: |
332-
mvn -B -nsu -DbackwardCompatTests -pl :bc-non-fips,:hierarchical-ledger-manager,:hostname-bookieid,:old-cookie-new-cluster,:recovery-no-password,:upgrade-direct,:yahoo-custom-version test
332+
mvn -B -nsu -DbackwardCompatTests -pl :bc-non-fips,:hierarchical-ledger-manager,:hostname-bookieid,:old-cookie-new-cluster,:recovery-no-password,:upgrade-direct test
333333
334334
- name: Upload container logs on failure
335335
uses: actions/upload-artifact@v4

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -2331,7 +2331,7 @@ List<BookieId> getCurrentEnsemble() {
23312331

23322332
/**
23332333
* Return a {@link WriteSet} suitable for reading a particular entry.
2334-
* This will include all bookies that are cotna
2334+
* This will include all bookies that are part of the ensemble for the entry.
23352335
*/
23362336
WriteSet getWriteSetForReadOperation(long entryId) {
23372337
if (stickyBookieIndex != STICKY_READ_BOOKIE_INDEX_UNSET) {

tests/backward-compat/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
<module>recovery-no-password</module>
3636
<module>old-cookie-new-cluster</module>
3737
<module>current-server-old-clients</module>
38-
<module>yahoo-custom-version</module>
3938
<module>bc-non-fips</module>
4039
</modules>
4140
<dependencyManagement>

tests/backward-compat/yahoo-custom-version/pom.xml

-32
This file was deleted.

0 commit comments

Comments
 (0)