Skip to content

Error paths in Bookie.start() don't stop the LifecycleComponent in Main.doMain #1891

Open
@athanatos

Description

@athanatos

It looks to me like calling shutdown() in the error paths doesn't actually result in the LifecycleComponent in Main.doMain shutting down. Normally, the DeathWatcher will raise an exception which'll be caught by the exception handler set in startComponent, but BookieServer.start() doesn't do that if the Bookie isn't running after start(). I think we just need to raise an exception in that branch in BookieServer.start().

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions