CAMEL-23703: camel-launcher - fix latest.properties path + Windows mvn invocation from review

Website manifest generator wrote latest.properties to the output root
while both installers fetch it from the releases/ subdirectory, so the
default versionless install would 404. Write it under releases/ and
align the generator and package-prepare tests with the installer
contract.

Also fix camel-package.bat to target the module via `mvn -f pom.xml`
(matching camel-package.sh) instead of `mvn -pl`, and tighten
install.sh version validation to reject leading/trailing/double-dot
versions for parity with install.ps1.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: ammachado

dsl/camel-jbang/camel-launcher/src/install/install.sh

@@ -35,7 +35,7 @@ fail() {
 is_valid_version() {
     v="$1"
     case "$v" in
-        '' | *[!0-9.]*) return 1 ;;
+        '' | .* | *. | *..* | *[!0-9.]*) return 1 ;;
     esac
     old_ifs="$IFS"
     IFS=.

dsl/camel-jbang/camel-launcher/src/jreleaser/bin/camel-package.bat

@@ -113,7 +113,7 @@ if not "%CAMEL_PACKAGE_TEST_VERSION%"=="" (
   )
   set "PROJECT_VERSION=%CAMEL_PACKAGE_TEST_VERSION%"
 ) else (
-  for /f "usebackq delims=" %%v in (`mvn -q -B -ntp -pl "%MODULE_DIR%" org.apache.maven.plugins:maven-help-plugin:3.5.1:evaluate -Dexpression=project.version -DforceStdout`) do set "PROJECT_VERSION=%%v"
+  for /f "usebackq delims=" %%v in (`mvn -q -B -ntp -f "%MODULE_DIR%\pom.xml" org.apache.maven.plugins:maven-help-plugin:3.5.1:evaluate -Dexpression=project.version -DforceStdout`) do set "PROJECT_VERSION=%%v"
 )
 
 if "!PROJECT_VERSION:~-8!"=="SNAPSHOT" (
@@ -197,7 +197,7 @@ if "%JRELEASER_GITHUB_TOKEN%"=="" set "JRELEASER_GITHUB_TOKEN=dry-run-placeholde
 @REM 1.25.0 plugin), used to select which packagers run for this channel; e.g. `lts`
 @REM excludes `scoop` by omitting it from !PACKAGERS!.
 echo Preparing packages for channel '%CHANNEL%' ^(packagers: !PACKAGERS!^)...
-call mvn -B -ntp -pl "%MODULE_DIR%" -Djreleaser.distributions=camel-cli -Djreleaser.packagers=!PACKAGERS! jreleaser:config jreleaser:prepare jreleaser:package -Djreleaser.dry.run=true
+call mvn -B -ntp -f "%MODULE_DIR%\pom.xml" -Djreleaser.distributions=camel-cli -Djreleaser.packagers=!PACKAGERS! jreleaser:config jreleaser:prepare jreleaser:package -Djreleaser.dry.run=true
 exit /b %ERRORLEVEL%
 
 :usage

dsl/camel-jbang/camel-launcher/src/jreleaser/java/WebsiteManifestGenerator.java

@@ -105,7 +105,7 @@ private static void run(String[] args) throws IOException {
         writeVersionManifest(releasesDir.resolve(version + ".properties"), manifest, version);
 
         if (latest) {
-            writeLatestManifest(output.resolve("latest.properties"), manifest, version);
+            writeLatestManifest(releasesDir.resolve("latest.properties"), manifest, version);
         }
     }
 

dsl/camel-jbang/camel-launcher/src/test/java/org/apache/camel/dsl/jbang/launcher/PackagePlanBatTest.java

@@ -195,7 +195,7 @@ void stableStagesInstallersAndWritesWebsiteManifests(@TempDir Path tmp) throws E
                 Files.readAllBytes(installPs1));
 
         Path versionManifest = websiteDir().resolve("camel-cli/releases/" + TEST_VERSION + ".properties");
-        Path latestManifest = websiteDir().resolve("camel-cli/latest.properties");
+        Path latestManifest = websiteDir().resolve("camel-cli/releases/latest.properties");
         assertTrue(Files.exists(versionManifest));
         assertTrue(Files.exists(latestManifest));
         String expected = "format=1\nversion=" + TEST_VERSION + "\ntar_sha256=" + sha256Hex(tar) + "\nzip_sha256="
@@ -219,7 +219,7 @@ void ltsStagesInstallersButDoesNotWriteLatest(@TempDir Path tmp) throws Exceptio
 
         assertEquals(0, r.exit, r.stderr);
         assertTrue(Files.exists(websiteDir().resolve("camel-cli/releases/" + TEST_VERSION + ".properties")));
-        assertFalse(Files.exists(websiteDir().resolve("camel-cli/latest.properties")),
+        assertFalse(Files.exists(websiteDir().resolve("camel-cli/releases/latest.properties")),
                 "LTS prepare must not create or modify latest.properties");
         assertTrue(Files.exists(recordFile));
     }

dsl/camel-jbang/camel-launcher/src/test/java/org/apache/camel/dsl/jbang/launcher/PackagePlanShTest.java

@@ -239,7 +239,7 @@ void stableStagesInstallersAndWritesWebsiteManifests(@TempDir Path tmp) throws E
                 Files.readAllBytes(installPs1));
 
         Path versionManifest = websiteDir().resolve("camel-cli/releases/" + TEST_VERSION + ".properties");
-        Path latestManifest = websiteDir().resolve("camel-cli/latest.properties");
+        Path latestManifest = websiteDir().resolve("camel-cli/releases/latest.properties");
         assertTrue(Files.exists(versionManifest));
         assertTrue(Files.exists(latestManifest));
         String expected = "format=1\nversion=" + TEST_VERSION + "\ntar_sha256=" + sha256Hex(tar) + "\nzip_sha256="
@@ -263,7 +263,7 @@ void ltsStagesInstallersButDoesNotWriteLatest(@TempDir Path tmp) throws Exceptio
 
         assertEquals(0, r.exit, r.stderr);
         assertTrue(Files.exists(websiteDir().resolve("camel-cli/releases/" + TEST_VERSION + ".properties")));
-        assertFalse(Files.exists(websiteDir().resolve("camel-cli/latest.properties")),
+        assertFalse(Files.exists(websiteDir().resolve("camel-cli/releases/latest.properties")),
                 "LTS prepare must not create or modify latest.properties");
         assertTrue(Files.exists(recordFile));
     }

dsl/camel-jbang/camel-launcher/src/test/java/org/apache/camel/dsl/jbang/launcher/WebsiteManifestGeneratorTest.java

@@ -102,7 +102,7 @@ void stableWritesVersionAndLatestManifests(@TempDir Path work) throws Exception
         assertEquals(0, r.exit, r.stderr);
         String expected = expectedManifest("4.22.0", sha256Hex(tar), sha256Hex(zip));
         Path versionFile = output.resolve("releases").resolve("4.22.0.properties");
-        Path latestFile = output.resolve("latest.properties");
+        Path latestFile = output.resolve("releases").resolve("latest.properties");
         assertEquals(expected, Files.readString(versionFile, StandardCharsets.UTF_8));
         assertArrayEquals(Files.readAllBytes(versionFile), Files.readAllBytes(latestFile),
                 "latest.properties must be byte-identical to the version manifest");
@@ -119,7 +119,8 @@ void ltsDoesNotWriteLatest(@TempDir Path work) throws Exception {
 
         assertEquals(0, r.exit, r.stderr);
         assertTrue(Files.exists(output.resolve("releases").resolve("4.18.5.properties")));
-        assertFalse(Files.exists(output.resolve("latest.properties")), "LTS run must not create latest.properties");
+        assertFalse(Files.exists(output.resolve("releases").resolve("latest.properties")),
+                "LTS run must not create latest.properties");
     }
 
     @Test
@@ -133,14 +134,14 @@ void repeatedRunIsIdempotent(@TempDir Path work) throws Exception {
         assertEquals(0, r1.exit, r1.stderr);
 
         byte[] versionBytesBefore = Files.readAllBytes(output.resolve("releases").resolve("4.22.0.properties"));
-        byte[] latestBytesBefore = Files.readAllBytes(output.resolve("latest.properties"));
+        byte[] latestBytesBefore = Files.readAllBytes(output.resolve("releases").resolve("latest.properties"));
 
         Result r2 = run("--version", "4.22.0", "--tar", tar.toString(), "--zip", zip.toString(), "--output",
                 output.toString(), "--latest", "true");
         assertEquals(0, r2.exit, r2.stderr);
 
         assertArrayEquals(versionBytesBefore, Files.readAllBytes(output.resolve("releases").resolve("4.22.0.properties")));
-        assertArrayEquals(latestBytesBefore, Files.readAllBytes(output.resolve("latest.properties")));
+        assertArrayEquals(latestBytesBefore, Files.readAllBytes(output.resolve("releases").resolve("latest.properties")));
     }
 
     @Test
@@ -174,7 +175,7 @@ void latestRollbackFails(@TempDir Path work) throws Exception {
         Result seed = run("--version", "4.23.0", "--tar", tar1.toString(), "--zip", zip1.toString(), "--output",
                 output.toString(), "--latest", "true");
         assertEquals(0, seed.exit, seed.stderr);
-        byte[] latestBefore = Files.readAllBytes(output.resolve("latest.properties"));
+        byte[] latestBefore = Files.readAllBytes(output.resolve("releases").resolve("latest.properties"));
 
         Path tar2 = writeFixture(work, "lo.tar.gz", "lo-tar");
         Path zip2 = writeFixture(work, "lo.zip", "lo-zip");
@@ -183,7 +184,7 @@ void latestRollbackFails(@TempDir Path work) throws Exception {
                 output.toString(), "--latest", "true");
 
         assertNotEquals(0, r.exit, "latest must not move backward to a lower version");
-        assertArrayEquals(latestBefore, Files.readAllBytes(output.resolve("latest.properties")));
+        assertArrayEquals(latestBefore, Files.readAllBytes(output.resolve("releases").resolve("latest.properties")));
         assertTrue(Files.exists(output.resolve("releases").resolve("4.22.0.properties")),
                 "the version-specific manifest is still written even if the latest update is rejected");
     }
@@ -201,7 +202,8 @@ void sameVersionChecksumConflictOnLatestFails(@TempDir Path work) throws Excepti
         Path zipStale = writeFixture(work, "stale.zip", "stale-zip");
         byte[] tamperedLatest
                 = expectedManifest("4.22.0", sha256Hex(tarStale), sha256Hex(zipStale)).getBytes(StandardCharsets.UTF_8);
-        Files.write(output.resolve("latest.properties"), tamperedLatest);
+        Files.createDirectories(output.resolve("releases"));
+        Files.write(output.resolve("releases").resolve("latest.properties"), tamperedLatest);
         assertFalse(Files.exists(output.resolve("releases").resolve("4.22.0.properties")));
 
         Path tarNew = writeFixture(work, "new.tar.gz", "new-tar-different");
@@ -211,7 +213,7 @@ void sameVersionChecksumConflictOnLatestFails(@TempDir Path work) throws Excepti
                 output.toString(), "--latest", "true");
 
         assertNotEquals(0, r.exit, "same-version checksum conflict against latest.properties must fail");
-        assertArrayEquals(tamperedLatest, Files.readAllBytes(output.resolve("latest.properties")),
+        assertArrayEquals(tamperedLatest, Files.readAllBytes(output.resolve("releases").resolve("latest.properties")),
                 "latest.properties must remain untouched after a rejected conflicting update");
         assertTrue(Files.exists(output.resolve("releases").resolve("4.22.0.properties")),
                 "the version-specific manifest still gets written since it did not previously exist");
@@ -235,7 +237,8 @@ void forwardUpdateSucceeds(@TempDir Path work) throws Exception {
 
         assertEquals(0, r.exit, r.stderr);
         String expected = expectedManifest("4.23.0", sha256Hex(tar2), sha256Hex(zip2));
-        assertEquals(expected, Files.readString(output.resolve("latest.properties"), StandardCharsets.UTF_8));
+        assertEquals(expected,
+                Files.readString(output.resolve("releases").resolve("latest.properties"), StandardCharsets.UTF_8));
         assertTrue(Files.exists(output.resolve("releases").resolve("4.22.0.properties")));
         assertTrue(Files.exists(output.resolve("releases").resolve("4.23.0.properties")));
     }
@@ -292,6 +295,7 @@ void handlesOutputPathsWithSpacesAndUnicode(@TempDir Path work) throws Exception
         String expected = expectedManifest("4.22.0", sha256Hex(tar), sha256Hex(zip));
         assertEquals(expected,
                 Files.readString(output.resolve("releases").resolve("4.22.0.properties"), StandardCharsets.UTF_8));
-        assertEquals(expected, Files.readString(output.resolve("latest.properties"), StandardCharsets.UTF_8));
+        assertEquals(expected,
+                Files.readString(output.resolve("releases").resolve("latest.properties"), StandardCharsets.UTF_8));
     }
 }