CASSANDRA-20256: Fix 0xe299233a8efdcefdl in AccordSimulationRunner #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifesdjeen
changed the title
| @@ -788,7 +788,13 @@ static CommandsForKeyUpdate updateUnmanaged(CommandsForKey cfk, SafeCommand safe | |||
| if (safeCommand.current().hasBeen(Status.Truncated)) | |||
| return cfk; | |||
|
|
|||
| Command.Committed command = safeCommand.current().asCommitted(); | |||
| Command orig = safeCommand.current(); | |||
| if (orig.saveStatus() == SaveStatus.Uninitialised) | |||
There was a problem hiding this comment.
maybe static import, and inline the two conditions? Also, good to use orig.txnId().is(EphemeralRead)
ifesdjeen
force-pushed
the
CASSANDRA-20256
branch
from
6f1a289 to
3bdf75c
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
183d5d0 to
cd7f495
Compare
ifesdjeen
force-pushed
the
CASSANDRA-20256
branch
from
3bdf75c to
6fa1c55
Compare
belliottsmith
approved these changes
Feb 10, 2025
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20256
ifesdjeen
force-pushed
the
CASSANDRA-20256
branch
from
6fa1c55 to
48b9fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.