Support asynchronous CommandStore message processing #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be implemented by e.g. scanning sstables
belliottsmith
force-pushed
the
rangetxns2
branch
from
6dd1a7d to
d2c1674
Compare
|
ping |
aweisberg
requested changes
Feb 1, 2023
There was a problem hiding this comment.
Can you rename zSlowSearcherandSlowSearchFunctionto something likeIncrementalSearcher` or whatever seems more descriptive and add a comment that the motivation is to allow implementations to process results without caching all of them or blocking for a long time or to avoid bringing them into the cache?
Otherwise yeah I am basically +1
|
Oh, somehow I missed you +1'd this. I'll rebase this perhaps onto bootstrap. |
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
6a9482b to
4a8566a
Compare
belliottsmith
force-pushed
the
trunk
branch
9 times, most recently
from
c3a1d8f to
efc6a38
Compare
belliottsmith
force-pushed
the
trunk
branch
3 times, most recently
from
289d5ea to
064735b
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
2edc7fb to
a271897
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
50d6ef9 to
bd0761c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While messages are submitted to a CommandStore asynchronously, the processing of a message is then expected to be synchronous. However, it would be beneficial particularly for large range transactions, but also for recovery, to be able to defer some work that might involve IO to after the command store processing completes, e.g. for calculating dependencies.