fix rebase and improve allocations in default logger

Author: joao-r-reis

conn_test.go

@@ -731,7 +731,7 @@ func TestStream0(t *testing.T) {
 		session: &Session{
 			types: GlobalTypes,
 		},
-		logger:  newInternalLoggerFromStdLogger(&defaultLogger{}, LogLevelNone),
+		logger:  NewLogger(LogLevelNone),
 	}
 
 	err := conn.recv(context.Background(), false)

logger.go

@@ -139,15 +139,18 @@ func (l *defaultLogger) write(prefix string, msg string, fields []LogField) {
 func writeFields(buf *bytes.Buffer, fields []LogField) {
 	for i, field := range fields {
 		if i > 0 {
-			buf.WriteString(strings.Join([]string{" ", field.Name, "=", field.Value.String()}, ""))
-		} else {
-			buf.WriteString(strings.Join([]string{field.Name, "=", field.Value.String()}, ""))
+			buf.WriteRune(' ')
 		}
+		buf.WriteString(field.Name)
+		buf.WriteRune('=')
+		buf.WriteString(field.Value.String())
 	}
 }
 
 func writeLogMsg(buf *bytes.Buffer, prefix string, msg string, fields []LogField) {
-	buf.WriteString(strings.Join([]string{prefix, msg, " "}, ""))
+	buf.WriteString(prefix)
+	buf.WriteString(msg)
+	buf.WriteRune(' ')
 	writeFields(buf, fields)
 }
 

metadata_test.go

@@ -43,7 +43,7 @@ func TestCompileMetadata(t *testing.T) {
 		cfg: ClusterConfig{
 			ProtoVersion: 1,
 		},
-		logger: newInternalLoggerFromStdLogger(&defaultLogger{}, LogLevelNone),
+		logger: NewLogger(LogLevelNone),
 		types:  GlobalTypes,
 	}
 	// V2 test - V2+ protocol is simpler so here are some toy examples to verify that the mapping works
@@ -434,7 +434,7 @@ func assertParseNonCompositeType(
 		cfg: ClusterConfig{
 			ProtoVersion: 4,
 		},
-		logger: newInternalLoggerFromStdLogger(&defaultLogger{}, LogLevelNone),
+		logger: NewLogger(LogLevelNone),
 		types:  GlobalTypes,
 	}
 	result, err := parseType(session, def)
@@ -475,7 +475,7 @@ func assertParseCompositeType(
 		cfg: ClusterConfig{
 			ProtoVersion: 4,
 		},
-		logger: newInternalLoggerFromStdLogger(&defaultLogger{}, LogLevelNone),
+		logger: NewLogger(LogLevelNone),
 		types:  GlobalTypes,
 	}
 	result, err := parseType(session, def)