Skip to content

Commit 77bed8b

Browse files
author
tengu-alt
committed
Remove global logger
By default, if the logger in the cluster config is not set, the NewSession() method sets a default logger instance which is a deprecated global variable. patch by Oleksandr Luzhniy; reviewed by João Reis for CASSGO-24
1 parent 7b7e6af commit 77bed8b

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212

1313
- Don't restrict server authenticator unless PasswordAuthentictor.AllowedAuthenticators is provided (CASSGO-19)
1414

15+
- Remove deprecated global logger (CASSGO-24)
16+
1517
### Fixed
1618

1719
## [1.7.0] - 2024-09-23

cluster.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ type ClusterConfig struct {
254254
HostDialer HostDialer
255255

256256
// Logger for this ClusterConfig.
257-
// If not specified, defaults to the global gocql.Logger.
257+
// If not specified, defaults to the gocql.defaultLogger.
258258
Logger StdLogger
259259

260260
// internal config for testing
@@ -298,7 +298,7 @@ func NewCluster(hosts ...string) *ClusterConfig {
298298

299299
func (cfg *ClusterConfig) logger() StdLogger {
300300
if cfg.Logger == nil {
301-
return Logger
301+
return &defaultLogger{}
302302
}
303303
return cfg.Logger
304304
}

conn.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ type ConnConfig struct {
151151

152152
func (c *ConnConfig) logger() StdLogger {
153153
if c.Logger == nil {
154-
return Logger
154+
return &defaultLogger{}
155155
}
156156
return c.Logger
157157
}

logger.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,3 @@ type defaultLogger struct{}
5858
func (l *defaultLogger) Print(v ...interface{}) { log.Print(v...) }
5959
func (l *defaultLogger) Printf(format string, v ...interface{}) { log.Printf(format, v...) }
6060
func (l *defaultLogger) Println(v ...interface{}) { log.Println(v...) }
61-
62-
// Logger for logging messages.
63-
// Deprecated: Use ClusterConfig.Logger instead.
64-
var Logger StdLogger = &defaultLogger{}

0 commit comments

Comments
 (0)