Skip to content

CASSGO-80 Update example and test code for 2.0 #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

CASSGO-80 Update example and test code for 2.0 #1897

merged 1 commit into from
Oct 3, 2025

Conversation

@joao-r-reis
Copy link
Contributor

@joao-r-reis joao-r-reis commented Jul 1, 2025 •
edited
Loading

Updates example and test code according to changes in 2.0.0 release (mostly deprecations).

Also adds examples for new 2.0 features.

@joao-r-reis joao-r-reis changed the title CASSGO-80 Update examples for 2.0 [WIP] CASSGO-80 Update examples for 2.0 Jul 3, 2025
@joao-r-reis joao-r-reis force-pushed the examples branch 2 times, most recently from d36c3e8 to 22c91cb Compare July 15, 2025 17:19
@joao-r-reis joao-r-reis changed the title [WIP] CASSGO-80 Update examples for 2.0 CASSGO-80 Update examples for 2.0 Jul 15, 2025
@joao-r-reis joao-r-reis changed the title CASSGO-80 Update examples for 2.0 CASSGO-80 Update example and test code for 2.0 Jul 15, 2025
lukasz-antoniak
lukasz-antoniak reviewed Sep 5, 2025
View reviewed changes
@lukasz-antoniak
Copy link
Member

lukasz-antoniak commented Sep 5, 2025

Shall we also add an example for types registration (like here)?

@joao-r-reis
Copy link
Contributor Author

joao-r-reis commented Sep 5, 2025

Shall we also add an example for types registration (like here)?

The current state of that feature is probably only useful for users that are using a different DB other than Cassandra like yugabyte. That example is for a yugabyte type that Cassandra itself doesn't support. Eventually we should add proper custom and udt type support to this API and at that point I think it will become useful to the common user and at that point I think it definitely deserves an example. As it stands I don't even have a way to verify that the jsonb example works because it requires a yugabyte db so I'd say we don't add one for now.

@lukasz-antoniak
Copy link
Member

lukasz-antoniak commented Sep 5, 2025

LGTM

@lukasz-antoniak lukasz-antoniak self-requested a review September 5, 2025 13:27
worryg0d
worryg0d approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@worryg0d worryg0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a little nit.

@joao-r-reis
Update example and test code for 2.0 release
a6ef165 
This patch updates the existing examples and tests according to the 2.0 changes (mostly deprecations) and adds new examples for new features added in 2.0.

Patch by João Reis; reviewed by Bohdan Siryk and Lukasz Antoniak for CASSGO-80
@joao-r-reis joao-r-reis merged commit 5fd2cdf into apache:trunk Oct 3, 2025
142 of 144 checks passed
@joao-r-reis joao-r-reis deleted the examples branch October 3, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasz-antoniak lukasz-antoniak lukasz-antoniak approved these changes

+1 more reviewer

@worryg0d worryg0d worryg0d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joao-r-reis @lukasz-antoniak @worryg0d