CASSGO-87 Fix issue where a timeout closes the connection. #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-antoniak
approved these changes
Sep 5, 2025
worryg0d
reviewed
Sep 10, 2025
Comment on lines
+1988
to
+2006
| // Deprecated: TimeoutLimit was removed so this is never returned by the driver now | ||
| ErrTooManyTimeouts = errors.New("gocql: too many query timeouts on the connection") | ||
|
|
||
| // Deprecated: Never returned by the driver | ||
| ErrQueryArgLength = errors.New("gocql: query argument length mismatch") |
Contributor
There was a problem hiding this comment.
Good decision to leave this so not to break existing code bases if they rely on these errors 👍
worryg0d
approved these changes
Sep 10, 2025
As part of CASSGO-12 which was supposedly just removing deprecated code, the driver now closes connections when a timeout occurs which was unintended. This patch fixes this issue. patch by João Reis; reviewed by Bohdan Siryk and Lukasz Antoniak for CASSGO-87
joao-r-reis
force-pushed
the
cassgo-87
branch
from
4278a30 to
9509900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of CASSGO-12 (#1768) which was supposedly just removing deprecated code, the driver now closes connections when a timeout occurs which was unintended. This patch fixes this issue.
patch by João Reis; reviewed by TBD for CASSGO-87