CASSGO-95: Fix Iter.RowData Values to point to concrete types #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were multiple issues with the previous RowData method. First, it was returning invalid values because it called c.Zero() instead of Zero on column. Second, it would've returned an interface to a pointer to an interface which is frustrating to work with. Now it restores the previous v1 behavior and returns pointers to the underlying types wrapped in an interface. Added tests to ensure the behavior is as expected. Patch by James Hartig; reviewed by João Reis for CASSGO-95
jameshartig
changed the title
jameshartig
force-pushed
the
x-rowdata-values
branch
from
ef9bdf9 to
c16bc76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple issues with the previous RowData method. First, it was returning invalid values because it called c.Zero() instead of Zero on column. Second, it would've returned an interface to a pointer to an interface which is frustrating to work with.
Now it restores the previous v1 behavior and returns pointers to the underlying types wrapped in an interface.
Added tests to ensure the behavior is as expected.
Patch by James Hartig for CASSGO-95