Skip to content

Commit bfbf51a

Browse files
committed
updates out-of-date docs on weaving
1 parent d09906a commit bfbf51a

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

persistence/jpa/adoc/modules/ROOT/pages/weaving.adoc

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ To enable static weaving, set xref:refguide:config:sections/eclipselink.adoc#ecl
2121
eclipselink.weaving=static
2222
----
2323

24-
WARNING: The ability to set `static` as a value is currently broken in 2.0.0/3.0.0; but a fix is available in the xref:comguide::nightly-builds.adoc[].
25-
26-
In addition, add the following to the `pom.xml` of all modules that contain JPA entities:
24+
In addition, add the link:https://github.com/ethlo/eclipselink-maven-plugin[eclipselink-maven-plugin] to the `pom.xml` of all modules that contain JPA entities, specifying the base package(s) to be weaved.:
2725

2826
[source,xml]
2927
.pom.xml
@@ -42,7 +40,9 @@ In addition, add the following to the `pom.xml` of all modules that contain JPA
4240
<goal>weave</goal>
4341
</goals>
4442
<configuration>
45-
<basePackage>domainapp.modules.simple.dom</basePackage> <!--.-->
43+
<basePackages>
44+
<basePackage>domainapp.modules.simple.dom</basePackage> <!--.-->
45+
</basePackages>
4646
</configuration>
4747
</execution>
4848
</executions>
@@ -62,10 +62,6 @@ NOTE: Thanks for the contribution via link:https://the-asf.slack.com/archives/CF
6262
[#runtime]
6363
== Dynamic (Runtime) Weaving
6464

65-
66-
WARNING: This is currently broken in 2.0.0/3.0.0.
67-
The workaround is to use xref:#compiletime[static] weaving instead.
68-
6965
The xref:docs:starters:simpleapp.adoc[SimpleApp] and xref:docs:starters:helloworld.adoc[HelloWorld] starter apps demonstrate the dynamic agent approach.
7066

7167
To enable runtime weaving, set xref:refguide:config:sections/eclipselink.adoc#eclipselink.weaving[eclipselink.weaving]:
@@ -82,7 +78,7 @@ It's also necessary to run the application with the `spring-instrument.jar` Java
8278
+
8379
[source,bash]
8480
----
85-
mvn dependency:fetchData -DgroupId=org.springframework -DartifactId=spring-instrument -Dversion=XXX
81+
mvn dependency:get -DgroupId=org.springframework -DartifactId=spring-instrument -Dversion=XXX
8682
----
8783
=
8884
changing "XXX" to the value that `${spring-framework.version}` resolves to, from the Causeway parent `pom.xml`.

0 commit comments

Comments
 (0)