Skip to content

Commit b131a40

Browse files
s0nskarSteNicholas
authored andcommitted
[MINOR] Fix PbSerDeUtilsTest failure
### What changes were proposed in this pull request? Fix PbSerDeUtilsTest failure for spark4 jobs ``` Error: /home/runner/work/celeborn/celeborn/common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala:851: comparing values of types Boolean and Boolean using `equals` unsafely bypasses cooperative equality; use `==` instead Error: [ERROR] one error found ``` https://github.com/apache/celeborn/actions/runs/27126367363/job/80055898287?pr=3720 ### Why are the changes needed? After this change #3675, some of tests are failing. ### Does this PR resolve a correctness bug? - [ ] Yes ### Does this PR introduce _any_ user-facing change? - [ ] Yes ### How was this patch tested? Existing UTs. Closes #3722 from s0nskar/CELEBORN-1577_fix_test. Authored-by: Sanskar Modi <sanskarmodi97@gmail.com> Signed-off-by: Nicholas Jiang <programgeek@163.com>
1 parent e5099f9 commit b131a40

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ class PbSerDeUtilsTest extends CelebornFunSuite {
848848
new TransportMessage(MessageType.HEARTBEAT_FROM_APPLICATION_RESPONSE, payload))
849849
.asInstanceOf[HeartbeatFromApplicationResponse]
850850
assert(
851-
fromTransportHeartbeatFromApplicationResponse.checkQuotaResponse.isAvailable.equals(true))
851+
fromTransportHeartbeatFromApplicationResponse.checkQuotaResponse.isAvailable)
852852
assert(fromTransportHeartbeatFromApplicationResponse.checkQuotaResponse.reason.equals(""))
853853
}
854854

0 commit comments

Comments
 (0)