Revert "Fix crashes of lateral join (#16958)"

This reverts commit 0f96542.

Author: yjhjstz

src/backend/cdb/cdbmutate.c

@@ -1960,107 +1960,3 @@ contains_outer_params(Node *node, void *context)
 	}
 	return expression_tree_walker(node, contains_outer_params, context);
 }
-
-typedef struct CTEMotionSearchContext
-{
-	plan_tree_base_prefix base; /* Required prefix for plan_tree_walker/mutator */
-	bool    bellowMotion;      /* True if we are under a Motion node */
-} CTEMotionSearchContext;
-
-/*
- * We can not pass params by a motion.
- * So there should not be any motion between RecursiveUnion and WorkTableScan.
- * Check if there is a motion between RecursiveUnion and WorkTableScan.
- */
-static bool
-cte_motion_search_walker(Node *node, CTEMotionSearchContext *context)
-{
-	if (node == NULL)
-		return false;
-
-	if (IsA(node, Motion))
-	{
-		bool savedBellowMotion = context->bellowMotion;
-		context->bellowMotion = true;
-		plan_tree_walker(node, cte_motion_search_walker, context, true);
-		context->bellowMotion = savedBellowMotion;
-		return false;
-	}
-	if (IsA(node, RecursiveUnion))
-	{
-		/*
-		 * We process RecursiveUnion recursively in create_recursiveunion_plan
-		 * here, we do not process repeatedly.
-		 */
-		return false;
-	}
-	if (IsA(node, WorkTableScan))
-	{
-		if (context->bellowMotion)
-		{
-			elog(ERROR, "Passing parameters across motion is not supported.");
-		}
-		return false;
-	}
-	return plan_tree_walker(node, cte_motion_search_walker, context, true);
-}
-
-/*
- * GPDB does not support pass params by a motion.
- * Check the rightplan of RecursiveUnion, wether there is a motion above WorkTableScan,
- * If true, throw an error.
- */
-void
-checkMotionAboveWorkTableScan(Node* node, PlannerInfo *root)
-{
-	CTEMotionSearchContext context;
-	planner_init_plan_tree_base(&context.base, root);
-	context.bellowMotion = false;
-
-	(void) cte_motion_search_walker(node, (void *) &context);
-}
-
-typedef struct MotionWithParamContext
-{
-	plan_tree_base_prefix base; /* Required prefix for plan_tree_walker/mutator */
-	Bitmapset  *nestLoopParams; /* nestloop params */
-} MotionWithParamContext;
-
-/*
- * check whether pass params by a motion
- */
-static bool
-checkMotionWithParamWalker(Node *node, MotionWithParamContext* motionWithParamcontext)
-{
-	if (node == NULL)
-		return false;
-
-	if (IsA(node, Motion))
-	{
-		Plan * plan = (Plan *) node;
-		Bitmapset  *finalExtParam;
-		if (!bms_is_empty(plan->extParam))
-		{
-			finalExtParam = bms_intersect(plan->extParam, motionWithParamcontext->nestLoopParams);
-			if (!bms_is_empty(finalExtParam))
-			{
-				elog(ERROR, "Passing parameters across motion is not supported.");
-			}
-		}
-	}
-
-	return plan_tree_walker(node, checkMotionWithParamWalker, motionWithParamcontext, true);
-}
-
-/*
- * We can not deliver a param by a motion node.
- * If there is a param on motion node, we should throw an error.
- */
-void
-checkMotionWithParam(Node *node, Bitmapset *bmsNestParams, PlannerInfo *root)
-{
-	MotionWithParamContext motionWithParamcontext;
-	motionWithParamcontext.nestLoopParams = bmsNestParams;
-	planner_init_plan_tree_base(&motionWithParamcontext.base, root);
-	checkMotionWithParamWalker(node, &motionWithParamcontext);
-}

src/backend/optimizer/plan/createplan.c

@@ -3088,11 +3088,6 @@ create_recursiveunion_plan(PlannerInfo *root, RecursiveUnionPath *best_path)
 								best_path->distinctList,
 								numGroups);
 
-	/*
-	 * Check whether there is a motion above WorkTableScan
-	 */
-	checkMotionAboveWorkTableScan((Node *)rightplan, root);
-
 	copy_generic_path_info(&plan->plan, (Path *) best_path);
 
 	return plan;

src/backend/optimizer/plan/subselect.c

@@ -3334,19 +3334,6 @@ finalize_plan(PlannerInfo *root, Plan *plan,
 									 gather_param,
 									 bms_union(nestloop_params, valid_params),
 									 scan_params);
-		/*
-		 * Currently GPDB doesn't fully support lateral, following sql will
-		 * pass params by a motion. Then cause panic in QE.
-		 * So add a walker to check whether motion in righttree of nestloop
-		 * will pass params, if true throw an error to avoid panic in QE.
-		 * explain SELECT * FROM
-		 * (VALUES (0.0),(10.4),(100.7)) v(nrows),
-		 * LATERAL (SELECT count(*) FROM test_tablesample
-		 *       TABLESAMPLE system_rows (nrows)) ss;
-		 */
-		if (IsA(plan, NestLoop) && !bms_is_empty(nestloop_params))
-			checkMotionWithParam((Node*) plan->righttree, nestloop_params, root);
-
 		/* ... and they don't count as parameters used at my level */
 		child_params = bms_difference(child_params, nestloop_params);
 		bms_free(nestloop_params);

src/include/cdb/cdbmutate.h

@@ -56,6 +56,5 @@ extern void remove_subquery_in_RTEs(Node *node);
 extern Plan *cdbpathtoplan_create_sri_plan(RangeTblEntry *rte, PlannerInfo *subroot, Path *subpath, int createplan_flags);
 
 extern bool contains_outer_params(Node *node, void *context);
-extern void checkMotionAboveWorkTableScan(Node* node, PlannerInfo *root);
-extern void checkMotionWithParam(Node *node, Bitmapset *bmsNestParams, PlannerInfo *root);
+
 #endif   /* CDBMUTATE_H */