Skip to content

Commit 0e639fb

Browse files
committed
Change PAX Plugin to Be Disabled by Default
Currently, the PAX is enabled by default in configure, and users need to explicitly disable it via `--disable-pax` option. However, this behavior is inconsistent with most of the other extensions under the contrib/ or gpcontrib/ dir, which are typically disabled by default unless explicitly enabled. PAX currently requires downloading several submodules during the build, for users without prior knowledge, this will lead to build failures. This PR is to change the default behavior of PAX to disabled, which will be more user-friendly for users. See: https://lists.apache.org/thread/q1n7hztzzydk1owhn73tc1b4chyhzx85
1 parent e492ba1 commit 0e639fb

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

configure

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -570,6 +570,7 @@ ac_hostname=`(hostname || uname -n) 2>/dev/null | sed 1q`
570570
#
571571
# Initializations.
572572
#
573+
ac_default_prefix=/usr/local
573574
ac_clean_files=
574575
ac_config_libobj_dir=.
575576
LIBOBJS=
@@ -759,8 +760,8 @@ HAVE_CXX14
759760
enable_gpcloud
760761
enable_shared_postgres_backend
761762
enable_mapreduce
762-
enable_catalog_ext
763763
enable_serverless
764+
enable_catalog_ext
764765
enable_orca
765766
autodepend
766767
PKG_CONFIG_LIBDIR
@@ -1608,7 +1609,7 @@ Optional Features:
16081609
--enable-cassert enable assertion checks (for debugging)
16091610
--disable-orca disable ORCA optimizer
16101611
--enable-catalog-ext enable Cloudberry catalog extension
1611-
--enable-serverless enable Cloudberry serverless mode
1612+
--enable-serverless use serverless mode of Cloudberry
16121613
--enable-mapreduce enable Cloudberry Mapreduce support
16131614
--disable-shared-postgres-backend
16141615
enable Cloudberry shared postgres backend support
@@ -1618,7 +1619,7 @@ Optional Features:
16181619
library)
16191620
--disable-preload-ic-module
16201621
disable preload interconnect module
1621-
--enable-pax enable pax support
1622+
--enable-pax enable PAX support
16221623
--disable-thread-safety disable thread-safety in client libraries
16231624
--enable-openssl-redirect
16241625
enable redirect openssl interface to internal
@@ -8380,7 +8381,7 @@ $as_echo "checking whether to build with catalog extension... $enable_catalog_ex
83808381

83818382

83828383
#
8383-
# Enable serverless mode
8384+
# --enable-serverless uses serverless mode of Cloudberry
83848385
#
83858386

83868387

@@ -8407,8 +8408,8 @@ else
84078408
fi
84088409

84098410

8410-
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: checking whether to use serverless architecture of Cloudberry ... $enable_serverless" >&5
8411-
$as_echo "checking whether to use serverless architecture of Cloudberry ... $enable_serverless" >&6; }
8411+
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: checking whether to use serverless mode of Cloudberry... $enable_serverless" >&5
8412+
$as_echo "checking whether to use serverless mode of Cloudberry... $enable_serverless" >&6; }
84128413

84138414

84148415
#
@@ -9101,6 +9102,7 @@ fi
91019102
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: checking whether to build with preload ic module ... $enable_preload_ic_module" >&5
91029103
$as_echo "checking whether to build with preload ic module ... $enable_preload_ic_module" >&6; }
91039104

9105+
91049106
#
91059107
# pax support
91069108
#
@@ -9124,13 +9126,14 @@ $as_echo "#define USE_PAX_STORAGE 1" >>confdefs.h
91249126
esac
91259127

91269128
else
9127-
enable_pax=yes
9128-
9129-
$as_echo "#define USE_PAX_STORAGE 1" >>confdefs.h
9129+
enable_pax=no
9130+
91309131
fi
91319132

9132-
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: checking whether to build with pax support ... $enable_pax" >&5
9133-
$as_echo "checking whether to build with pax support ... $enable_pax" >&6; }
9133+
9134+
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: checking whether to build with PAX support ... $enable_pax" >&5
9135+
$as_echo "checking whether to build with PAX support ... $enable_pax" >&6; }
9136+
91349137

91359138
#
91369139
# Include directories

configure.ac

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -928,8 +928,8 @@ AC_SUBST(enable_preload_ic_module)
928928
#
929929
# pax support
930930
#
931-
PGAC_ARG_BOOL(enable, pax, yes,
932-
[disable PAX support],
931+
PGAC_ARG_BOOL(enable, pax, no,
932+
[enable PAX support],
933933
[AC_DEFINE(USE_PAX_STORAGE, 1,
934934
[Define to 1 to support PAX])])
935935
AC_MSG_RESULT([checking whether to build with PAX support ... $enable_pax])

0 commit comments

Comments
 (0)