Add Support for the diskquota extension in Apache Cloudberry

[nicko858]

Description

The diskquota extension, previously available in vanilla Greenplum 6, is a powerful tool for managing disk space usage and monitoring table sizes. This feature request proposes adding official support for the diskquota extension in Apache Cloudberry to enhance database management capabilities.

Use case/motivation

Use Cases:

• Enforcing per-schema or per-role disk quotas to prevent excessive disk usage.

• Monitoring table sizes in background to optimize storage and performance.

Questions to the Maintainers:

Is there a plan to include official support for the diskquota extension in Apache Cloudberry?

Are there any technical challenges or roadmap considerations that need to be addressed before implementing this feature?

We believe adding support for diskquota will significantly enhance Apache Cloudberry's usability and appeal to enterprise users. Looking forward to your feedback!

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

[tuhaihe]

Hey @nicko858, thanks for contributing this idea. Do you mean this project¹?

If it is, IMO, we can create one forked version for it in the non-official Cloudberry eco-projects GitHub org². Would you like to help maintain it? I can grant you access to the Org.

Footnotes

1. https://github.com/greenplum-db/diskquota-archive ↩

2. https://github.com/cloudberry-contrib ↩

[tuhaihe]

Cool @nicko858 Once new updates on it, will let you know.

[tuhaihe]

A late follow-up:

I created a branch to support Cloudberry with the help of AI: https://github.com/tuhaihe/diskquota/tree/support-cloudberry. It has been tested and can now build for Cloudberry 2.0. However, a few tests failed when running make installcheck after installation.

Feel free to try it out and share your feedback.

[nicko858]

Thank you for sharing this work, it’s great!
We’ll test the build in our staging environment against our main scenarios, and once that’s done we’ll get back to you with feedback.

[nicko858]

Hello @tuhaihe !
Sorry for the long delay in getting back to you— we've been swamped with production workloads and only now managed to build and run our key scenarios against the branch you shared (https://github.com/tuhaihe/diskquota/tree/support-cloudberry). The build completed successfully for Cloudberry 2.0 on rhel8 environment, and the extension installed without issues.
In our staging environment, we tested the core quota enforcement for per-schema limits and background table size monitoring, which worked as expected across our main workloads

So far, the issues you observed during make installcheck do not seem to impact the extension’s core functionality in our scenarios, but we will continue to monitor this closely as we roll it out and use it in production.
Thanks.

CC: @vsbace @my-ship-it @jianlirong

[tuhaihe]

Great news! Thanks for your feedback.

[vsbace]

Hello, we are planning to use the DISK QUOTA extension in Cloudberry DB.
And I think this extension is mostly used in current Greenplum installations,
and it will be popular if it can be built/compile with Cloudberry DB.

[vsbace]

Well i have a one problem when i was trying to compile DISKQUOTA extension on Cloudberry 1.6.0
and i need help in this situation if it possible:

/opt/diskquota/src/diskquota.c: In function ‘disk_quota_worker_main’: /opt/diskquota/src/diskquota.c:508:25: error: too many arguments to function ‘init_ps_display’ 508 | init_ps_display("bgworker:", "[diskquota]", dbname, _errmsg); | ^~~~~~~~~~~~~~~ In file included from /opt/diskquota/src/diskquota.c:41: /usr/local/cloudberry-db-1.6.0-ucb/include/postgresql/server/utils/ps_status.h:21:13: note: declared here 21 | extern void init_ps_display(const char *fixed_part); | ^~~~~~~~~~~~~~~ /opt/diskquota/src/diskquota.c:512:25: error: too many arguments to function ‘init_ps_display’ 512 | init_ps_display("bgworker:", "[diskquota]", dbname, | ^~~~~~~~~~~~~~~ /usr/local/cloudberry-db-1.6.0-ucb/include/postgresql/server/utils/ps_status.h:21:13: note: declared here 21 | extern void init_ps_display(const char *fixed_part); | ^~~~~~~~~~~~~~~ /opt/diskquota/src/diskquota.c:541:9: error: too many arguments to function ‘init_ps_display’ 541 | init_ps_display("bgworker:", "[diskquota]", dbname, ""); | ^~~~~~~~~~~~~~~ /usr/local/cloudberry-db-1.6.0-ucb/include/postgresql/server/utils/ps_status.h:21:13: note: declared here 21 | extern void init_ps_display(const char *fixed_part); | ^~~~~~~~~~~~~~~ /opt/diskquota/src/diskquota.c: In function ‘diskquota_status_schema_version’: /opt/diskquota/src/diskquota.c:1625:9: warning: implicit declaration of function ‘StrNCpy’; did you mean ‘strncpy’? [-Wimplicit-function-declaration] 1625 | StrNCpy(ret_version, version, sizeof(ret_version) - 1); | ^~~~~~~ | strncpy make[2]: *** [CMakeFiles/diskquota.dir/build.make:76: CMakeFiles/diskquota.dir/src/diskquota.c.o] Ошибка 1 make[1]: *** [CMakeFiles/Makefile2:123: CMakeFiles/diskquota.dir/all] Ошибка 2

On Greenplum 7 we see another structure of parameters of function - "init_ps_display":
extern void init_ps_display(const char *username, const char *dbname, const char *host_info, const char *initial_str);

[vsbace]

DISKQUOTA source i taken from this place:
https://github.com/arenadata/diskquota

[vsbace]

Hi, i had solved this problem but catched the next problem:
root@cbdb01:/opt/diskquota/build# make [ 12%] Building C object CMakeFiles/diskquota.dir/src/diskquota_utility.c.o /opt/diskquota/src/diskquota_utility.c: In function ‘__get_oid_auto_case_convert’: /opt/diskquota/src/diskquota_utility.c:630:17: warning: implicit declaration of function ‘StrNCpy’; did you mean ‘strncpy’? [-Wimplicit-function-declaration] 630 | StrNCpy(b, name + 1, l - 1); // trim the '"'. unlike strncpy, StrNCpy will ensure b[l-1] = '\0' | ^~~~~~~ | strncpy /opt/diskquota/src/diskquota_utility.c: In function ‘diskquota_get_appendonly_aux_oid_list’: /opt/diskquota/src/diskquota_utility.c:1502:42: error: ‘AppendOnlyRelidIndexId’ undeclared (first use in this function); did you mean ‘AppendOnlyRelationId’? 1502 | scan = systable_beginscan(aorel, AppendOnlyRelidIndexId, true /*indexOk*/, NULL /*snapshot*/, 1 /*nkeys*/, &skey); | ^~~~~~~~~~~~~~~~~~~~~~ | AppendOnlyRelationId /opt/diskquota/src/diskquota_utility.c:1502:42: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [CMakeFiles/diskquota.dir/build.make:90: CMakeFiles/diskquota.dir/src/diskquota_utility.c.o] Ошибка 1 make[1]: *** [CMakeFiles/Makefile2:123: CMakeFiles/diskquota.dir/all] Ошибка 2 make: *** [Makefile:156: all] Ошибка 2

[tuhaihe]

Hey, I forked one here: http://github.com/cloudberry-contrib/diskquota. Welcome to help create PR to fix these issues.

[my-ship-it]

Hi @nicko858, do you still have problems or resolved by yourself? Feel free to share building results if you need any help form the community.

[nicko858]

Hi @my-ship-it!
We’ll try the solution proposed by @tuhaihe in the previous thread.

[jianlirong]

@nicko858 , any update of this issue? Looking forward to getting this feature ready. Thanks.