Skip to content

Commit 4876761

Browse files
ui: Allow font-awesome icon usage and optimise icon size inconsistency (#9744)
Signed-off-by: Rohit Yadav <[email protected]> Co-authored-by: dahn <[email protected]>
1 parent 971a5b2 commit 4876761

File tree

4 files changed

+31
-15
lines changed

4 files changed

+31
-15
lines changed

ui/src/components/menu/SMenu.vue

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@
5858
v-if="item.meta.icon && typeof (item.meta.icon) === 'string'"
5959
:icon="item.meta.icon"
6060
@click="() => { handleClickParentMenu(item) }" />
61+
<font-awesome-icon
62+
v-else-if="item.meta.icon && Array.isArray(item.meta.icon)"
63+
:icon="item.meta.icon"
64+
class="anticon"
65+
:style="[$store.getters.darkMode ? { color: 'rgba(255, 255, 255, 0.65)' } : { color: '#888' }]"
66+
@click="() => { handleClickParentMenu(item) }" />
6167
<span>{{ $t(item.meta.title) }}</span>
6268
</router-link>
6369
</a-menu-item>

ui/src/components/view/InfoCard.vue

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@
3434
<resource-icon :image="getImage(resource.icon && resource.icon.base64image || images.template || images.iso || resourceIcon)" size="4x" style="margin-right: 5px"/>
3535
</span>
3636
<span v-else>
37-
<os-logo v-if="resource.ostypeid || resource.ostypename" :osId="resource.ostypeid" :osName="resource.ostypename" size="4x" @update-osname="setResourceOsType"/>
37+
<os-logo v-if="resource.ostypeid || resource.ostypename" :osId="resource.ostypeid" :osName="resource.ostypename" size="3x" @update-osname="setResourceOsType"/>
3838
<render-icon v-else-if="typeof $route.meta.icon ==='string'" style="font-size: 36px" :icon="$route.meta.icon" />
3939
<font-awesome-icon
4040
v-else-if="$route.meta.icon && Array.isArray($route.meta.icon)"
4141
:icon="$route.meta.icon"
42-
size="4x"
42+
size="3x"
4343
class="anticon"
4444
:style="[$store.getters.darkMode ? { color: 'rgba(255, 255, 255, 0.65)' } : { color: '#888' }]" />
4545
<render-icon v-else style="font-size: 36px" :svgIcon="$route.meta.icon" />
@@ -179,7 +179,10 @@
179179
<div class="resource-detail-item" v-if="('cpunumber' in resource && 'cpuspeed' in resource) || resource.cputotal">
180180
<div class="resource-detail-item__label">{{ $t('label.cpu') }}</div>
181181
<div class="resource-detail-item__details">
182-
<appstore-outlined />
182+
<font-awesome-icon
183+
:icon="['fa-solid', 'fa-microchip']"
184+
class="anticon"
185+
:style="[$store.getters.darkMode ? { color: 'rgba(255, 255, 255, 0.65)' } : { color: '#888' }]" />
183186
<span v-if="'cpunumber' in resource && 'cpuspeed' in resource">{{ resource.cpunumber }} CPU x {{ (resource.cpuspeed / 1000.0).toFixed(2) }} GHz
184187
<a-tooltip placement="top">
185188
<template #title>
@@ -214,7 +217,11 @@
214217
<div class="resource-detail-item" v-if="'memory' in resource">
215218
<div class="resource-detail-item__label">{{ $t('label.memory') }}</div>
216219
<div class="resource-detail-item__details">
217-
<bulb-outlined />{{ resource.memory + ' ' + $t('label.mb.memory') }}
220+
<font-awesome-icon
221+
:icon="['fa-solid', 'fa-memory']"
222+
class="anticon"
223+
:style="[$store.getters.darkMode ? { color: 'rgba(255, 255, 255, 0.65)' } : { color: '#888' }]" />
224+
{{ resource.memory + ' ' + $t('label.mb.memory') }}
218225
</div>
219226
<div>
220227
<span v-if="resource.memorykbs && resource.memoryintfreekbs">
@@ -355,7 +362,10 @@
355362
v-for="(eth, index) in resource.nic"
356363
:key="eth.id"
357364
style="margin-left: -24px; margin-top: 5px;">
358-
<api-outlined />
365+
<font-awesome-icon
366+
:icon="['fa-solid', 'fa-ethernet']"
367+
class="anticon"
368+
:style="[$store.getters.darkMode ? { color: 'rgba(255, 255, 255, 0.65)' } : { color: '#888' }]" />
359369
<strong>eth{{ index }}</strong>&nbsp;
360370
<copy-label :label="eth.ip6address ? eth.ipaddress + ', ' + eth.ip6address : eth.ipaddress" />&nbsp;
361371
<a-tag v-if="eth.isdefault">
@@ -380,7 +390,11 @@
380390
v-for="network in resource.networks"
381391
:key="network.id"
382392
style="margin-top: 5px;">
383-
<api-outlined />{{ network.name }}
393+
<font-awesome-icon
394+
:icon="['fa-solid', 'fa-ethernet']"
395+
class="anticon"
396+
:style="[$store.getters.darkMode ? { color: 'rgba(255, 255, 255, 0.65)' } : { color: '#888' }]" />
397+
{{ network.name }}
384398
<span v-if="resource.defaultnetworkid === network.id">
385399
({{ $t('label.default') }})
386400
</span>

ui/src/components/view/ListView.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
<span v-if="record.icon && record.icon.base64image">
4444
<resource-icon :image="record.icon.base64image" size="2x"/>
4545
</span>
46-
<os-logo v-else :osId="record.ostypeid" :osName="record.osdisplayname" size="2x" />
46+
<os-logo v-else :osId="record.ostypeid" :osName="record.osdisplayname" size="xl" />
4747
</span>
4848
<span style="min-width: 120px" >
4949
<QuickView
@@ -57,12 +57,12 @@
5757
</span>
5858
<span v-if="$showIcon() && !['vm', 'vnfapp'].includes($route.path.split('/')[1])" style="margin-right: 5px">
5959
<resource-icon v-if="$showIcon() && record.icon && record.icon.base64image" :image="record.icon.base64image" size="2x"/>
60-
<os-logo v-else-if="record.ostypename" :osName="record.ostypename" size="2x" />
60+
<os-logo v-else-if="record.ostypename" :osName="record.ostypename" size="xl" />
6161
<render-icon v-else-if="typeof $route.meta.icon ==='string'" style="font-size: 16px;" :icon="$route.meta.icon"/>
6262
<render-icon v-else style="font-size: 16px;" :svgIcon="$route.meta.icon" />
6363
</span>
6464
<span v-else :style="{ 'margin-right': record.ostypename ? '5px' : '0' }">
65-
<os-logo v-if="record.ostypename" :osName="record.ostypename" size="1x" />
65+
<os-logo v-if="record.ostypename" :osName="record.ostypename" size="xl" />
6666
</span>
6767

6868
<span v-if="record.hasannotations">

ui/src/core/ext.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,11 @@
1818
import { library } from '@fortawesome/fontawesome-svg-core'
1919
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'
2020

21-
// import { fab } from '@fortawesome/free-brands-svg-icons'
22-
// import { fas } from '@fortawesome/free-solid-svg-icons'
23-
// import { far } from '@fortawesome/free-regular-svg-icons'
24-
2521
import { faCentos, faUbuntu, faDebian, faSuse, faRedhat, faFedora, faLinux, faFreebsd, faApple, faWindows, faJava } from '@fortawesome/free-brands-svg-icons'
26-
import { faCompactDisc, faCameraRetro, faDharmachakra } from '@fortawesome/free-solid-svg-icons'
22+
import { fas, faCompactDisc, faCameraRetro, faDharmachakra } from '@fortawesome/free-solid-svg-icons'
2723

2824
library.add(faCentos, faUbuntu, faDebian, faSuse, faRedhat, faFedora, faLinux, faFreebsd, faApple, faWindows, faJava)
29-
library.add(faCompactDisc, faCameraRetro, faDharmachakra)
25+
library.add(fas, faCompactDisc, faCameraRetro, faDharmachakra)
3026

3127
export default {
3228
install: (app) => {

0 commit comments

Comments
 (0)