change PhysicalNetworkTrafficType.isolationMethods -> string

Author: madhukar93

Diff for: api/src/main/java/org/apache/cloudstack/api/response/PhysicalNetworkResponse.java

@@ -139,6 +139,10 @@ public void setIsolationMethods(List<String> isolationMethods) {
         this.isolationMethods = buf.delete(buf.length() - 1, buf.length()).toString();
     }
 
+    public String getIsolationMethods() {
+        return isolationMethods;
+    }
+
     public void setName(String name) {
         this.name = name;
     }

Diff for: api/src/main/java/org/apache/cloudstack/api/response/TrafficTypeResponse.java

@@ -25,8 +25,6 @@
 import com.cloud.network.PhysicalNetworkTrafficType;
 import com.cloud.serializer.Param;
 
-import java.util.List;
-
 @EntityReference(value = PhysicalNetworkTrafficType.class)
 public class TrafficTypeResponse extends BaseResponse {
 
@@ -67,7 +65,7 @@ public class TrafficTypeResponse extends BaseResponse {
 
     @SerializedName(ApiConstants.ISOLATION_METHODS)
     @Param(description = "isolation methods for the physical network traffic")
-    private List<String> isolationMethods;
+    private String isolationMethods;
 
     @SerializedName(ApiConstants.OVM3_NETWORK_LABEL)
     @Param(description = "The network name of the physical device dedicated to this traffic on an OVM3 host")
@@ -142,13 +140,14 @@ public void setOvm3Label(String ovm3Label) {
         this.ovm3NetworkLabel = ovm3Label;
     }
 
-    public List<String> getIsolationMethods() {
+    public String getIsolationMethods() {
         return isolationMethods;
     }
 
-    public void setIsolationMethods(List<String> isolationMethods) {
+    public void setIsolationMethods(String isolationMethods) {
         this.isolationMethods = isolationMethods;
     }
+
     public String getVlan() {
         return vlan;
     }

Diff for: server/src/main/java/com/cloud/api/ApiResponseHelper.java

@@ -3082,7 +3082,10 @@ public TrafficTypeResponse createTrafficTypeResponse(PhysicalNetworkTrafficType
         PhysicalNetwork pnet = ApiDBUtils.findPhysicalNetworkById(result.getPhysicalNetworkId());
         if (pnet != null) {
             response.setPhysicalNetworkId(pnet.getUuid());
-            response.setIsolationMethods(pnet.getIsolationMethods());
+            // using PhysicalNetworkResponse only to convert isolation methods to string
+            PhysicalNetworkResponse pnetResponse = new PhysicalNetworkResponse();
+            pnetResponse.setIsolationMethods(pnet.getIsolationMethods());
+            response.setIsolationMethods(pnetResponse.getIsolationMethods());
         }
         if (result.getTrafficType() != null) {
             response.setTrafficType(result.getTrafficType().toString());