improved log messages

Author: skattoju4

Diff for: core/src/main/java/com/cloud/storage/template/SwiftVolumeDownloader.java

@@ -237,7 +237,7 @@ public long download(boolean resume, DownloadCompleteCallback callback) {
             return 0;
         }
 
-        LOGGER.info("Starting download from " + downloadUrl + " to staging with size " + remoteSize + " bytes to "+filePath);
+        LOGGER.info("Starting download from " + downloadUrl + " to staging with size " + remoteSize + " bytes to " + srcFile.getPath());
         final Date downloadStart = new Date();
 
         try (FileOutputStream fileOutputStream = new FileOutputStream(srcFile);) {
@@ -257,7 +257,8 @@ public long download(boolean resume, DownloadCompleteCallback callback) {
             outputStream.close();
             inputStream.close();
         } catch (IOException e) {
-            LOGGER.error("Exception when downloading from url to staging nfs:" + e.getMessage(), e);
+            LOGGER.error("Exception when downloading from url " + downloadUrl + " with remote size " + remoteSize
+                    + " to staging nfs path " + srcFile.getPath() + " : " + e.getMessage(), e);
             status = Status.RECOVERABLE_ERROR;
             return 0;
         }

Diff for: plugins/storage/image/swift/src/main/java/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java

@@ -116,7 +116,7 @@ public void createAsync(DataStore dataStore, DataObject data, AsyncCompletionCal
         }
 
         if (downloadCommand == null){
-            String errMsg = "Unable to build download command, DataObject is of neither VOLUME or TEMPLATE type";
+            String errMsg = "Unable to build download command, unsupported DataObject is of type " + data.getType().toString();
             s_logger.error(errMsg);
             throw new CloudRuntimeException(errMsg);
         }

Diff for: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java

@@ -1167,11 +1167,12 @@ protected File downloadFromUrlToNfs(String url, NfsTO nfs, String path, String n
             try (FileOutputStream outputStream = new FileOutputStream(destFile);) {
                 entity.writeTo(outputStream);
             } catch (IOException e) {
-                s_logger.error("downloadFromUrlToNfs:Exception:" + e.getMessage(), e);
+                s_logger.error(String.format("Unable to download from url [%s] to nfs path [%s] due to [%s]",
+                        url,destFile.getPath(),e.getMessage()), e);
             }
             return new File(destFile.getAbsolutePath());
         } catch (IOException e) {
-            s_logger.error("Faild to get url:" + url + ", due to " + e.toString());
+            s_logger.error("Failed to get url:" + url + ", due to " + e.toString(), e);
             throw new CloudRuntimeException(e);
         }
     }
@@ -1210,7 +1211,7 @@ protected Answer registerTemplateOnSwift(DownloadCommand cmd) {
             try (FileInputStream fs = new FileInputStream(file)) {
                 md5sum = DigestUtils.md5Hex(fs);
             } catch (IOException e) {
-                s_logger.error("Failed to get md5sum: " + file.getAbsoluteFile());
+                s_logger.error("Failed to get md5sum: " + file.getAbsoluteFile(), e);
             }
 
             DownloadAnswer answer = new DownloadAnswer(null, 100, null, VMTemplateStorageResourceAssoc.Status.DOWNLOADED, swiftPath, swiftPath, virtualSize, file.length(), md5sum);