Dynamic global configurations for LDAPS requires restart

[rajujith]

problem

The global configurations ldap.truststore.password and ldap.truststore used for enabling the SSL/TLS support for LDAP i.e LDAPS are set type dynamic and it is expected that updating them do not require cloudstack-management service restart. However this is the current behaviour.

• On setting the value for the above parameters for the first time it works without a restart.
• If you update it later on it requires service restart. There is no message returned to admin that it requires restart.

Considering the configuration is set as dynamic it should take effect without a service restart.

versions

4.19.1.3

The steps to reproduce the bug

1. Create a truststore and set the values ldap.truststore.password and ldap.truststore
   2.Add LDAPS server
2. Create a new truststore for different server or rename current file or create an empty one and update the configuration in the step 1.
3. Delete the server added in the step 2 and add it back. Or add a new LDAPS server based on the new truststore.
4. You will recognize that the updated values don't take effect until next service restart.
   ...

What to do about it?

The updated values should take effect without service restart.

[Pearl1594]

@rajujith I don't seem to be able to reproduce it, I used a debugger to test it. I followed the given steps:

• Setup all the necessary ldap configs including ldap.truststore and ldap.truststore.password
• created an ldap server
• Placed a debugger at:

  cloudstack/plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapConfiguration.java

  Lines 281 to 287 in 4d572fa

  	public String getTrustStore(Long domainId) {
  	return ldapTrustStore.valueIn(domainId);
  	}
  	public String getTrustStorePassword(Long domainId) {
  	return ldapTrustStorePassword.valueIn(domainId);
  	}

  
  It returned the set values in the global setting
• then proceeded to update the values of ldap.truststore and ldap.truststore.password
• Deleted the previously added ldap server and re-added it
• Debugger hits the same point as mentioned on step 3 - it returns the latest values set in the global config.