[VMware] 4.19.2.0 console access not working after the upgrade

[nvazquez]

Problem

After upgrading from 4.18.2.3 to 4.19.2.0 it was observed some VMs created before the upgrade cannot access the console anymore. This was debugged and its caused by a NullPointerException on: https://github.com/apache/cloudstack/blob/4.19.2.0/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L7519

The is caused by searching a VM from internal name through the Vmware SDK, and the target VM is never retrieved by Vmware, causing the NPE

Versions

4.19.2.0 on Vmware (tested 8.0)

What to do about it?

No response

[NuxRo]

Good catch, @nvazquez !

[nvazquez]

Thanks @NuxRo - it seems like the regression is caused by the improvement PR #9925 as an unintended side effect of the VMs listing through the SDK.