storageusagedisablethreshold flag reported incorrectly by listStoragePoolsMetrics command

[eduardovra]

problem

This makes the storage pool reach the disable threshold before the notification threshold.

In the sources:

metricsResponse.setStorageAllocatedDisableThreshold(poolResponse.getDiskSizeTotal(), poolResponse.getDiskSizeUsed(), poolResponse.getOverProvisionFactor(), storageDisableThreshold);

Should be:

metricsResponse.setStorageAllocatedDisableThreshold(poolResponse.getDiskSizeTotal(), poolResponse.getDiskSizeAllocated(), poolResponse.getOverProvisionFactor(), storageDisableThreshold);

Reference:

https://github.com/apache/cloudstack/blob/main/plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java#L647

versions

CloudStack 4.20.1.0

The steps to reproduce the bug

1. Open the UI
2. Go to the primary storage section

What to do about it?

No response

[sureshanaparti]

Fixed in #11366