Featured private templates

[rajujith]

ISSUE TYPE

• Improvement Request

COMPONENT NAME

Templates

CLOUDSTACK VERSION

4.18.1, ALL

SUMMARY

Currently, CloudStack expects the featured templates to be public as well if they are not public the featured templates are not listed in the featured templates tab in UI. Either in the template filter 'Featured' in the Images pane or in the instance deployment wizard. Why featured templates are tied to the property 'public' can this dependency be removed to allow private templates as well as Featured ones?

[DaanHoogland]

@rajujith i marked this as bug as the api also does not show featured non-public templates when using templatefilter=featured, but does when using templatefilter=all.

I actually think we should be able to directly list on the basis of the flags, i.e. ispublic=false or isfeatured=true. Wgat do you think?

[rajujith]

@DaanHoogland I do agree to list directly on the basis of the flags ispublic=false or isfeatured=true.

[shwstppr]

listTempalates API currently doesn't have ispublic or isfeatured parameters. Also, I'm not in favour of adding such new parameter as it would add confusion to the existing templatefilter parameter.
I feel we should be able to fix the issue listing non-public featured template by removing this condition,
https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L4505

[weizhouapache]

@rajujith @shwstppr @DaanHoogland @sureshanaparti
according to the source code, it looks featured templates must be public

https://github.com/apache/cloudstack/blob/4.19.0.1/api/src/main/java/com/cloud/template/VirtualMachineTemplate.java#L71-L80