[router] make a distinction between fatal errors, warnings and unknown as healthcheck result #10710

DaanHoogland · 2025-04-14T14:27:32Z

Description

This PR...

Fixes: #9800

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

added some fake tests to test the UI:

DaanHoogland · 2025-04-14T14:27:58Z

@blueorangutan package

blueorangutan · 2025-04-14T14:30:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-04-14T14:36:16Z

Codecov Report

Attention: Patch coverage is 23.73737% with 151 lines in your changes missing coverage. Please review.

Project coverage is 16.13%. Comparing base (17e062a) to head (bd5d2f2).

Files with missing lines	Patch %	Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java	4.08%	138 Missing and 3 partials ⚠️
.../api/response/RouterHealthCheckResultResponse.java	0.00%	2 Missing ⚠️
...m/cloud/network/dao/RouterHealthCheckResultVO.java	0.00%	2 Missing ⚠️
.../apache/cloudstack/framework/config/ConfigKey.java	66.66%	2 Missing ⚠️
...oud/network/lb/ElasticLoadBalancerManagerImpl.java	0.00%	1 Missing ⚠️
.../network/lb/InternalLoadBalancerVMManagerImpl.java	0.00%	1 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	92.85%	1 Missing ⚠️
...a/com/cloud/network/router/CommandSetupHelper.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.20   #10710    +/-   ##
==========================================
  Coverage     16.13%   16.13%            
  Complexity    13218    13218            
==========================================
  Files          5651     5652     +1     
  Lines        496758   496645   -113     
  Branches      60183    60162    -21     
==========================================
+ Hits          80138    80150    +12     
+ Misses       407696   407572   -124     
+ Partials       8924     8923     -1

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`16.98% <23.73%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-04-14T15:45:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13050

DaanHoogland · 2025-04-15T07:38:58Z

@blueorangutan test

blueorangutan · 2025-04-15T07:40:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-04-15T21:45:48Z

[SF] Trillian test result (tid-12989)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10710-t12989-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-04-25T13:10:34Z

@blueorangutan package

blueorangutan · 2025-04-25T13:12:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-25T14:38:34Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13183

DaanHoogland · 2025-04-26T15:04:09Z

@blueorangutan test

blueorangutan · 2025-04-26T15:06:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-04-26T15:53:31Z

[SF] Trillian Build Failed (tid-13166)

…healthchecks

DaanHoogland · 2025-05-02T08:39:48Z

@blueorangutan package

blueorangutan · 2025-05-02T08:42:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-02T08:51:42Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13239

blueorangutan · 2025-05-06T12:08:38Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13274

DaanHoogland · 2025-05-06T13:24:53Z

@blueorangutan test

blueorangutan · 2025-05-06T13:26:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-05-07T06:53:55Z

[SF] Trillian test result (tid-13221)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59934 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10710-t13221-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_router_internal_adv	`Failure`	14.93	test_routers.py

DaanHoogland · 2025-05-08T10:39:28Z

@blueorangutan test keepEnv

blueorangutan · 2025-05-08T10:40:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-05-09T03:23:48Z

[SF] Trillian test result (tid-13240)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57408 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10710-t13240-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_router_internal_adv	`Failure`	14.94	test_routers.py

github-actions · 2025-05-09T09:10:06Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2025-05-15T10:19:53Z

@blueorangutan package

blueorangutan · 2025-05-15T10:22:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-15T11:36:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13396

boring-cyborg bot added component:api component:networking component:vpc labels Apr 14, 2025

DaanHoogland changed the title ~~Ghi9800 update vr on setting change~~ [router] make a distinction between fatal errors, warnings and unknown as healthcheck result Apr 14, 2025

DaanHoogland linked an issue Apr 14, 2025 that may be closed by this pull request

Suggestion: When Global Setting such as (network.loadbalancer.haproxy.max.conn) is changed, mark VR as 'Requires Upgrade' instead of marking it as failed healtcheck. #9800

Open

DaanHoogland marked this pull request as ready for review April 18, 2025 10:48

DaanHoogland changed the base branch from 4.19 to 4.20 April 25, 2025 11:52

DaanHoogland added this to the 4.20.1 milestone Apr 25, 2025

DaanHoogland force-pushed the ghi9800-updateVrOnSettingChange branch 3 times, most recently from 546c094 to 73f40ee Compare April 25, 2025 13:10

boring-cyborg bot added the component:UI label Apr 25, 2025

DaanHoogland mentioned this pull request Apr 25, 2025

Suggestion: When Global Setting such as (network.loadbalancer.haproxy.max.conn) is changed, mark VR as 'Requires Upgrade' instead of marking it as failed healtcheck. #9800

Open

boring-cyborg bot added component:virtual-router Python Warning... Python code Ahead! labels Apr 28, 2025

DaanHoogland added 2 commits May 2, 2025 10:39

config cleanup

2cb6778

[routers] distiction between fatal failure and warning or unknown on …

4ce429d

…healthchecks

Daan Hoogland added 2 commits May 2, 2025 10:39

UI status for router health checks

b0b986d

change some error and succes to warning or unknown

c5157a6

DaanHoogland force-pushed the ghi9800-updateVrOnSettingChange branch from eb83516 to c5157a6 Compare May 2, 2025 08:39

deal with warnings

f870fad

github-actions bot added the status:has-conflicts label May 9, 2025

Merge branch '4.20' into ghi9800-updateVrOnSettingChange

bd5d2f2

github-actions bot removed the status:has-conflicts label May 9, 2025

[router] make a distinction between fatal errors, warnings and unknown as healthcheck result #10710

Are you sure you want to change the base?

[router] make a distinction between fatal errors, warnings and unknown as healthcheck result #10710

Uh oh!

Conversation

DaanHoogland commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

DaanHoogland commented Apr 14, 2025

Uh oh!

blueorangutan commented Apr 14, 2025

Uh oh!

codecov bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Apr 14, 2025

Uh oh!

DaanHoogland commented Apr 15, 2025

Uh oh!

blueorangutan commented Apr 15, 2025

Uh oh!

blueorangutan commented Apr 15, 2025

Uh oh!

DaanHoogland commented Apr 25, 2025

Uh oh!

blueorangutan commented Apr 25, 2025

Uh oh!

blueorangutan commented Apr 25, 2025

Uh oh!

DaanHoogland commented Apr 26, 2025

Uh oh!

blueorangutan commented Apr 26, 2025

Uh oh!

blueorangutan commented Apr 26, 2025

Uh oh!

DaanHoogland commented May 2, 2025

Uh oh!

blueorangutan commented May 2, 2025

Uh oh!

blueorangutan commented May 2, 2025

Uh oh!

blueorangutan commented May 6, 2025

Uh oh!

DaanHoogland commented May 6, 2025

Uh oh!

blueorangutan commented May 6, 2025

Uh oh!

blueorangutan commented May 7, 2025

Uh oh!

DaanHoogland commented May 8, 2025

Uh oh!

blueorangutan commented May 8, 2025

Uh oh!

blueorangutan commented May 9, 2025

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

DaanHoogland commented May 15, 2025

Uh oh!

blueorangutan commented May 15, 2025

Uh oh!

blueorangutan commented May 15, 2025

Uh oh!

Uh oh!

DaanHoogland commented Apr 14, 2025 •

edited

Loading

codecov bot commented Apr 14, 2025 •

edited

Loading