Skip to content

pre-commit upgrade codespell and fix spelling #10144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pre-commit upgrade codespell and fix spelling #10144

wants to merge 2 commits into from
+122 −105

Conversation

jbampton
Copy link
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov Codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.28571% with 36 lines in your changes missing coverage. Please review.

Project coverage is 16.31%. Comparing base (576b97b) to head (2dd1020).

Files with missing lines Patch % Lines
...cloud/storage/resource/VmwareStorageProcessor.java 0.00% 10 Missing ⚠️
...om/cloud/deploy/DeploymentPlanningManagerImpl.java 0.00% 6 Missing ⚠️
...e/resource/StorageSubsystemCommandHandlerBase.java 0.00% 1 Missing and 1 partial ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 2 Missing ⚠️
.../xenserver/resource/XenServerStorageProcessor.java 0.00% 2 Missing ⚠️
...nserver/resource/Xenserver625StorageProcessor.java 50.00% 2 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 2 Missing ⚠️
.../CheckDataStoreStoragePolicyComplianceCommand.java 0.00% 1 Missing ⚠️
...torage/allocator/AbstractStoragePoolAllocator.java 0.00% 1 Missing ⚠️
...ypervisor/ovm3/resources/Ovm3StorageProcessor.java 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #10144   +/-   ##
=========================================
  Coverage     16.31%   16.31%           
+ Complexity    13464    13462    -2     
=========================================
  Files          5676     5676           
  Lines        499418   499418           
  Branches      60395    60395           
=========================================
+ Hits          81491    81497    +6     
+ Misses       408855   408844   -11     
- Partials       9072     9077    +5
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests 17.17% <14.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbampton jbampton closed this Dec 28, 2024
@jbampton jbampton reopened this Dec 28, 2024
DaanHoogland
DaanHoogland approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could refuse a lot of those spellos but lgtm like this as well (non native ;)

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11930

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11939

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@jbampton jbampton mentioned this pull request Mar 29, 2025
Open
@jbampton jbampton force-pushed the pre-commit-update-codespell branch from b833c07 to ef08967 Compare April 25, 2025 16:27
@DaanHoogland
Copy link
Contributor

@vishesh92 , lgty?

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13189

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13172)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54043 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t13172-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_restore_vm_strict_tags_failure Failure 58.55 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Failure 58.74 test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure Failure 5.71 test_vm_strict_host_tags.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishesh92 vishesh92 vishesh92 left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees
No one assigned
Labels
component:agent component:api component:hyperv component:integration-test component:kvm component:networking component:simulator component:storage component:vmware component:XenServer Python Warning... Python code Ahead!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbampton @blueorangutan @DaanHoogland @vishesh92