StringUtils.repeat(String, [String,] int) now throws IllegalArgumentException (#1644)

StringUtils.repeat(String, [String,] int) now throws IllegalArgumentException instead of NegativeArraySizeException (#1644).

Author: garydgregory

src/main/java/org/apache/commons/lang3/StringUtils.java

@@ -351,7 +351,7 @@ public static String abbreviate(final String str, final String abbrevMarker, fin
      * @throws IllegalArgumentException if the width is too small.
      * @since 3.6
      */
-    public static String abbreviate(final String str, String abbrevMarker, int offset, final int maxWidth) {
+    public static String abbreviate(final String str, String abbrevMarker, final int offset, final int maxWidth) {
         if (isEmpty(str)) {
             return str;
         }
@@ -6117,7 +6117,12 @@ public static String repeat(final String repeat, final int count) {
         if (inputLength == 1 && count <= PAD_LIMIT) {
             return repeat(repeat.charAt(0), count);
         }
-        final int outputLength = inputLength * count;
+        final int outputLength;
+        try {
+            outputLength = Math.multiplyExact(inputLength, count);
+        } catch (final Exception e) {
+            throw new IllegalArgumentException("The requested result is too large for a String.");
+        }
         switch (inputLength) {
         case 1:
             return repeat(repeat.charAt(0), count);

src/test/java/org/apache/commons/lang3/StringUtilsTest.java

@@ -1718,28 +1718,27 @@ void testRepeat_StringInt() {
         final String str = StringUtils.repeat("a", 10000);  // bigger than pad limit
         assertEquals(10000, str.length());
         assertTrue(StringUtils.containsOnly(str, 'a'));
+        assertThrows(IllegalArgumentException.class, () -> StringUtils.repeat("aa", 1_073_741_824));
     }
 
     @Test
     void testRepeat_StringStringInt() {
         assertNull(StringUtils.repeat(null, null, 2));
         assertNull(StringUtils.repeat(null, "x", 2));
         assertEquals("", StringUtils.repeat("", null, 2));
-
         assertEquals("", StringUtils.repeat("ab", "", 0));
         assertEquals("", StringUtils.repeat("", "", 2));
-
         assertEquals("xx", StringUtils.repeat("", "x", 3));
-
         assertEquals("?, ?, ?", StringUtils.repeat("?", ", ", 3));
+        assertThrows(IllegalArgumentException.class, () -> StringUtils.repeat("?", ", ", 1_073_741_824));
     }
 
     /**
      * Test method for 'StringUtils.replaceEach(String, String[], String[])'
      */
     @Test
     void testReplace_StringStringArrayStringArray() {
-        //JAVADOC TESTS START
+        // JAVADOC TESTS START
         assertNull(StringUtils.replaceEach(null, new String[]{"a"}, new String[]{"b"}));
         assertEquals(StringUtils.replaceEach("", new String[]{"a"}, new String[]{"b"}), "");
         assertEquals(StringUtils.replaceEach("aba", null, null), "aba");
@@ -1751,7 +1750,7 @@ void testReplace_StringStringArrayStringArray() {
         assertEquals(StringUtils.replaceEach("aba", new String[]{null}, new String[]{"a"}), "aba");
         assertEquals(StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"w", "t"}), "wcte");
         assertEquals(StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}), "dcte");
-        //JAVADOC TESTS END
+        // JAVADOC TESTS END
 
         assertEquals("bcc", StringUtils.replaceEach("abc", new String[]{"a", "b"}, new String[]{"b", "c"}));
         assertEquals("q651.506bera", StringUtils.replaceEach("d216.102oren",