Skip to content

Commit 9e8e8ac

Browse files
committed
fix(ios)! WebView top to top edge
- The WebView top was constrained to safe area top, which made a transparent gap in the top safe area. - breaking change: The site which should be dispayed in the in-app browser, have to care about the safe areas, otherwise it would be behind the camera and statusbar, which was before not the case
1 parent b83a9b7 commit 9e8e8ac

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/ios/CDVWKInAppBrowser.m

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -897,8 +897,8 @@ - (void)createViews
897897
//
898898
// Case 1: Toolbar and Address label not visible
899899
if (!toolbarVisible && !addressLabelVisible) {
900-
// Webview top to safe area top
901-
[self.webView.topAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor].active = YES;
900+
// Webview top to top edge
901+
[self.webView.topAnchor constraintEqualToAnchor:self.view.topAnchor].active = YES;
902902
// WebView bottom to bottom edge
903903
[self.webView.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor].active = YES;
904904
}
@@ -911,13 +911,13 @@ - (void)createViews
911911
[self.toolbar.topAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor].active = YES;
912912
// Webview top to Toolbar bottom
913913
[self.webView.topAnchor constraintEqualToAnchor:self.toolbar.bottomAnchor].active = YES;
914-
// WebView to bottom edge
914+
// WebView bottom to bottom edge
915915
[self.webView.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor].active = YES;
916916

917917
// Toolbar is at bottom (default)
918918
} else {
919-
// WebView top to safe area top
920-
[self.webView.topAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor].active = YES;
919+
// WebView top to top edge
920+
[self.webView.topAnchor constraintEqualToAnchor:self.view.topAnchor].active = YES;
921921
// WebView bottom to Toolbar top
922922
[self.webView.bottomAnchor constraintEqualToAnchor:self.toolbar.topAnchor].active = YES;
923923
// Toolbar bottom to safe area bottom
@@ -927,8 +927,8 @@ - (void)createViews
927927

928928
// Case 3: Toolbar not visible, Address label visible
929929
if (!toolbarVisible && addressLabelVisible) {
930-
// Webview top to safe area top
931-
[self.webView.topAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor].active = YES;
930+
// Webview top to top edge
931+
[self.webView.topAnchor constraintEqualToAnchor:self.view.topAnchor].active = YES;
932932
// Address label top to WebView bottom
933933
[self.addressLabel.topAnchor constraintEqualToAnchor:self.webView.bottomAnchor].active = YES;
934934
// Address label bottom to safe area bottom
@@ -950,8 +950,8 @@ - (void)createViews
950950

951951
// Toolbar is at bottom (default)
952952
} else {
953-
// WebView top to safe area top
954-
[self.webView.topAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor].active = YES;
953+
// WebView top to top edge
954+
[self.webView.topAnchor constraintEqualToAnchor:self.view.topAnchor].active = YES;
955955
// WebView bottom to Address label top
956956
[self.webView.bottomAnchor constraintEqualToAnchor:self.addressLabel.topAnchor].active = YES;
957957
// Address label bottom to Toolbar top

0 commit comments

Comments
 (0)