Skip to content

Commit 44d0683

Browse files
Fix layout of the "Solve Conflicts" modal (#1470)
* Fix: misaligned buttons in the doc conflicts confirmation modal * Fix: npm audit failures * Fix: bump Node used in CI to 20 to address failure with latest 'npm'
1 parent 87a7377 commit 44d0683

File tree

5 files changed

+76
-76
lines changed

5 files changed

+76
-76
lines changed

.github/workflows/main.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/checkout@v4
1515
- uses: actions/setup-node@v4
1616
with:
17-
node-version: '18'
17+
node-version: '20'
1818
- name: Install npm packages
1919
run: |
2020
npm install -g npm@latest
@@ -39,7 +39,7 @@ jobs:
3939
- uses: actions/checkout@v4
4040
- uses: actions/setup-node@v4
4141
with:
42-
node-version: '18'
42+
node-version: '20'
4343
cache: 'npm'
4444
- run: ./bin/build-couchdb-dev.sh
4545
env:

app/addons/documents/assets/scss/revision-browser.scss

+7-2
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,12 @@ div#dashboard-content div.revision-wrapper {
142142
}
143143

144144
.delete-conflicts-modal {
145-
.do-not-show-again label {
146-
font-size: 13px;
145+
.do-not-show-again {
146+
&.form-check {
147+
padding-left: 2em;
148+
}
149+
label {
150+
font-size: 13px;
151+
}
147152
}
148153
}

app/addons/documents/rev-browser/components/confirmmodal.js

+12-19
Original file line numberDiff line numberDiff line change
@@ -54,31 +54,24 @@ export default class ConfirmModal extends React.Component {
5454
</p>
5555
</Modal.Body>
5656
<Modal.Footer>
57-
5857
<div className='col-12'>
5958
<Form.Check type="checkbox"
6059
className='do-not-show-again'
6160
label="Do not show this warning message again"
6261
onChange={() => { this.setState({checked: !this.state.checked }); }} />
6362
</div>
64-
65-
<div className="col-auto">
66-
<Button href="#"
67-
variant="cf-cancel"
68-
className='cancel-link'
69-
onClick={this.close}
70-
data-bypass="true"
71-
>
72-
Cancel
73-
</Button>
74-
</div>
75-
<div className="col-auto">
76-
<ConfirmButton
77-
onClick={this.onDeleteConflicts}
78-
text="Delete Revisions"
79-
variant="danger" />
80-
</div>
81-
63+
<Button href="#"
64+
variant="cf-cancel"
65+
className='cancel-link'
66+
onClick={this.close}
67+
data-bypass="true"
68+
>
69+
Cancel
70+
</Button>
71+
<ConfirmButton
72+
onClick={this.onDeleteConflicts}
73+
text="Delete Revisions"
74+
variant="danger" />
8275
</Modal.Footer>
8376
</Modal>
8477
);

package-lock.json

+54-52
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"fauxton": "./bin/fauxton"
1111
},
1212
"engines": {
13-
"node": "^18"
13+
"node": "^20"
1414
},
1515
"devDependencies": {
1616
"@babel/cli": "^7.18.10",

0 commit comments

Comments
 (0)