Skip to content

Commit 9b3fc63

Browse files
Bump net.sourceforge.pmd:pmd-java from 7.10.0 to 7.11.0 (#2297)
* Bump net.sourceforge.pmd:pmd-java from 7.10.0 to 7.11.0 Bumps [net.sourceforge.pmd:pmd-java](https://github.com/pmd/pmd) from 7.10.0 to 7.11.0. - [Release notes](https://github.com/pmd/pmd/releases) - [Changelog](https://github.com/pmd/pmd/blob/main/docs/render_release_notes.rb) - [Commits](pmd/pmd@pmd_releases/7.10.0...pmd_releases/7.11.0) --- updated-dependencies: - dependency-name: net.sourceforge.pmd:pmd-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix PMD violations --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
1 parent a12016c commit 9b3fc63

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

parent/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@
435435
<dependency>
436436
<groupId>net.sourceforge.pmd</groupId>
437437
<artifactId>pmd-java</artifactId>
438-
<version>7.10.0</version>
438+
<version>7.11.0</version>
439439
</dependency>
440440
</dependencies>
441441
<configuration>

rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/AbstractStartEndEventProducer.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.apache.cxf.service.model.ServiceInfo;
3030
import org.omg.CORBA.ORB;
3131

32+
@SuppressWarnings("PMD.FinalFieldCouldBeStatic")
3233
public abstract class AbstractStartEndEventProducer implements
3334
CorbaTypeEventProducer {
3435

rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaOctetSequenceEventProducer.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import javax.xml.stream.events.Attribute;
2626
import javax.xml.stream.events.Namespace;
2727

28+
@SuppressWarnings("PMD.FinalFieldCouldBeStatic")
2829
public class CorbaOctetSequenceEventProducer implements CorbaTypeEventProducer {
2930

3031
int state;

systests/transports/src/test/java/org/apache/cxf/systest/http/HTTPConduitIoExceptionsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public void testServiceUnavailable() throws Exception {
8282

8383
exception.expect(WebServiceException.class);
8484
exception.expectCause(new TypeSafeMatcher<Throwable>() {
85-
private final String message = "HTTP response '503: Service Unavailable' when "
85+
private static final String message = "HTTP response '503: Service Unavailable' when "
8686
+ "communicating with http://localhost:" + BadServer.PORT + "/Mortimer";
8787

8888
@Override
@@ -109,7 +109,7 @@ public void testNotFound() throws Exception {
109109

110110
exception.expect(WebServiceException.class);
111111
exception.expectCause(new TypeSafeMatcher<Throwable>() {
112-
private final String message = "HTTP response '404: Not Found' when "
112+
private static final String message = "HTTP response '404: Not Found' when "
113113
+ "communicating with http://localhost:" + BadServer.PORT + "/Mortimer";
114114

115115
@Override

systests/transports/src/test/java/org/apache/cxf/systest/servlet/NoSpringServletClientTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@
5151

5252
public class NoSpringServletClientTest extends AbstractServletTest {
5353
private static final String PORT = NoSpringServletServer.PORT;
54+
private static final String SERVICE_URL = "http://localhost:" + PORT + "/soap/";
5455
private static Bus serverBus;
5556
private static NoSpringServletServer server;
5657
private final QName portName = new QName("http://apache.org/hello_world_soap_http", "SoapPort");
57-
private final String serviceURL = "http://localhost:" + PORT + "/soap/";
5858

5959
@BeforeClass
6060
public static void startServers() throws Exception {
@@ -73,7 +73,7 @@ public static void shutdownServer() throws Exception {
7373

7474
@Test
7575
public void testBasicConnection() throws Exception {
76-
SOAPService service = new SOAPService(new URL(serviceURL + "Greeter?wsdl"));
76+
SOAPService service = new SOAPService(new URL(SERVICE_URL + "Greeter?wsdl"));
7777
Greeter greeter = service.getPort(portName, Greeter.class);
7878
try {
7979
String reply = greeter.greetMe("test");
@@ -90,7 +90,7 @@ public void testBasicConnection() throws Exception {
9090
@Test
9191
public void testHelloService() throws Exception {
9292
JaxWsProxyFactoryBean cpfb = new JaxWsProxyFactoryBean();
93-
String address = serviceURL + "Hello";
93+
String address = SERVICE_URL + "Hello";
9494
cpfb.setServiceClass(Hello.class);
9595
cpfb.setAddress(address);
9696
Hello hello = (Hello) cpfb.create();
@@ -133,7 +133,7 @@ private void startServer() {
133133
@Test
134134
public void testGetServiceList() throws Exception {
135135
try (CloseableHttpClient client = HttpClients.createDefault()) {
136-
final HttpGet method = new HttpGet(serviceURL + "/services");
136+
final HttpGet method = new HttpGet(SERVICE_URL + "/services");
137137

138138
try (CloseableHttpResponse res = client.execute(method)) {
139139
HTMLDocumentImpl doc = parse(res.getEntity().getContent());
@@ -144,9 +144,9 @@ public void testGetServiceList() throws Exception {
144144
s.add(l.getHref());
145145
}
146146
assertEquals("There should be 3 links for the service", 3, links.size());
147-
assertTrue(s.contains(serviceURL + "Greeter?wsdl"));
148-
assertTrue(s.contains(serviceURL + "Hello?wsdl"));
149-
assertTrue(s.contains(serviceURL + "?wsdl"));
147+
assertTrue(s.contains(SERVICE_URL + "Greeter?wsdl"));
148+
assertTrue(s.contains(SERVICE_URL + "Hello?wsdl"));
149+
assertTrue(s.contains(SERVICE_URL + "?wsdl"));
150150
assertEquals("text/html", getContentType(res));
151151
}
152152
}

0 commit comments

Comments
 (0)