address review comments

Author: parthchandra

spark/src/main/spark-4.1/org/apache/comet/shims/CometExprShim.scala

@@ -155,7 +155,7 @@ trait CometExprShim extends CommonStringExprs {
               inputs,
               binding)
           case (Literal(parser: ToTimeParser, _), "parse", args)
-              if i.dataType.isInstanceOf[TimeType] && parser.fmt.isEmpty =>
+              if i.dataType.isInstanceOf[TimeType] && parser.fmt.isEmpty && args.size == 1 =>
             val childExprs = args.map(exprToProtoInternal(_, inputs, binding))
             val optExpr =
               scalarFunctionExprToProtoWithReturnType("to_time", i.dataType, true, childExprs: _*)
@@ -167,7 +167,7 @@ trait CometExprShim extends CommonStringExprs {
       case TryEval(i: Invoke) =>
         (i.targetObject, i.functionName, i.arguments) match {
           case (Literal(parser: ToTimeParser, _), "parse", args)
-              if i.dataType.isInstanceOf[TimeType] && parser.fmt.isEmpty =>
+              if i.dataType.isInstanceOf[TimeType] && parser.fmt.isEmpty && args.size == 1 =>
             val childExprs = args.map(exprToProtoInternal(_, inputs, binding))
             val optExpr = scalarFunctionExprToProtoWithReturnType(
               "to_time",

spark/src/test/resources/sql-tests/expressions/datetime/to_time.sql

@@ -245,3 +245,16 @@ SELECT try_to_time(' 1:00:00 PM')
 -- to_time with format pattern falls back to Spark (not supported natively)
 query expect_fallback(invoke is not supported)
 SELECT to_time('12:30:45', 'HH:mm:ss')
+
+statement
+CREATE TABLE test_to_time_col_fmt(s STRING, f STRING) USING parquet
+
+statement
+INSERT INTO test_to_time_col_fmt VALUES
+  ('14.30.00', 'HH.mm.ss'),
+  ('1230', 'HHmm')
+
+-- A non-foldable format column should fall back to Spark because Comet does
+-- not implement the format-pattern variant of to_time.
+query expect_fallback(invoke is not supported)
+SELECT to_time(s, f) FROM test_to_time_col_fmt