Commit e05de25
Re-export moved proto types under deprecated paths
The proto-models extraction moved the prost-generated types from
`datafusion_proto::generated::*` into `datafusion_proto_models::generated::*`.
cargo-semver-checks flagged ~200 paths as removed, even though my
`pub use datafusion_proto_models::protobuf::*` wildcard re-export should
have covered them — turns out wildcard-of-wildcard re-exports aren't
followed by every static-analysis tool.
Two fixes:
1. `pub mod protobuf` now re-exports directly from
`datafusion_proto_models::generated::datafusion::*` (the leaf module
where the types are originally declared) instead of going through
`datafusion_proto_models::protobuf::*` (itself a `pub use ::*`). One
level of indirection avoided.
2. New `pub mod generated` re-exports the legacy `generated::datafusion::*`
and `generated::datafusion_common` paths, with `#[deprecated]` pointing
downstream callers at `datafusion_proto::protobuf` /
`datafusion_proto_common::protobuf_common`.
Together: every `datafusion_proto::generated::*` and
`datafusion_proto::protobuf::*` path that compiled on `main` continues
to compile, with deprecation warnings on the legacy `generated::*`
paths.
The other API breaks (`PhysicalPlanNodeExt` trait import for inherent-
looking methods, `from_proto`/`try_from_proto` over `From`/`TryFrom` for
foreign-foreign pairs) can't be made backwards-compatible without
re-introducing the orphan rule problem; they're flagged in the PR
description.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 15c706e commit e05de25
1 file changed
Lines changed: 34 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
141 | 174 | | |
142 | 175 | | |
143 | 176 | | |
| |||
0 commit comments