Skip to content

Commit e81d77f

Browse files
adriangbclaude
andcommitted
ci(proto): preserve historical paths to avoid spurious semver findings
The Apache/datafusion CI's `Comment on pull request` job posts semver-check findings as a PR comment via bash; with the volume of cross-crate re-exports in this PR, the comment body blew past `Argument list too long`. Two source-level changes shrink the findings list: - Re-export the `datafusion_common` package types from inside `proto-models::generated::datafusion` so historical paths like `datafusion_proto::generated::datafusion::JoinType` keep resolving. Pre-change, those types were embedded duplicates inside the proto crate's `mod datafusion`; after the absorb in C2 they only lived under the common package mod, which cargo-semver-checks flagged as "removed". - Add a `pbjson` feature alias on `datafusion-proto` that forwards to `json`. Pre-change, `pbjson` was an optional dep, which auto-created a `pbjson` feature; consumers depending on `datafusion-proto/pbjson` would otherwise break. No runtime behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 289f9f1 commit e81d77f

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

datafusion/proto-models/src/generated/mod.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ pub mod datafusion_proto_common {
3636
pub mod datafusion {
3737
include!("datafusion.rs");
3838

39+
// Re-export the `datafusion_common` package types from inside `mod datafusion`
40+
// so historical paths like `datafusion_proto::generated::datafusion::JoinType`
41+
// (which used to be embedded duplicates of the common types) keep resolving.
42+
pub use super::datafusion_proto_common::*;
43+
3944
#[cfg(feature = "json")]
4045
include!("datafusion.serde.rs");
4146
}

datafusion/proto/Cargo.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@ name = "datafusion_proto"
3737
[features]
3838
default = ["parquet"]
3939
json = ["serde_json", "datafusion-proto-models/json"]
40+
# Back-compat alias: pbjson used to be an optional dep auto-creating a `pbjson`
41+
# feature. After the proto-models extraction, datafusion-proto no longer has a
42+
# direct pbjson dep; the JSON serde plumbing forwards through proto-models.
43+
# Keep `pbjson` as a feature alias for `json` so downstream `features = ["pbjson"]`
44+
# continues to work.
45+
pbjson = ["json"]
4046
parquet = ["datafusion-datasource-parquet", "datafusion-common/parquet", "datafusion/parquet"]
4147
avro = ["datafusion-datasource-avro"]
4248

0 commit comments

Comments
 (0)