Merge pull request #109 from apache/download_dependency

leerho · web-flow · commit da50e52b609f · 2024-12-11T09:20:36.000-08:00
download datasketches-cpp instead of using submodule
diff --git a/.gitmodules b/.gitmodules
@@ -1,3 +0,0 @@
-[submodule "datasketches-cpp"]
-	path = datasketches-cpp
-	url = https://github.com/apache/datasketches-cpp
diff --git a/Makefile b/Makefile
@@ -20,10 +20,17 @@ MODULES := theta tuple cpc hll kll fi tdigest req
 $(MODULES):
 	$(MAKE) -C $@
 
-.PHONY: all clean init $(MODULES)
+.PHONY: all clean init test unittest readme $(MODULES)
 .DEFAULT_GOAL := all
 
-all: $(MODULES)
+all: datasketches-cpp $(MODULES)
+
+DATASKETCHES_CPP_VERSION = 5.1.0
+datasketches-cpp:
+	wget https://github.com/apache/datasketches-cpp/archive/refs/tags/$(DATASKETCHES_CPP_VERSION).zip
+	mv $(DATASKETCHES_CPP_VERSION).zip datasketches-cpp-$(DATASKETCHES_CPP_VERSION).zip
+	unzip datasketches-cpp-$(DATASKETCHES_CPP_VERSION).zip
+	ln -s datasketches-cpp-$(DATASKETCHES_CPP_VERSION) datasketches-cpp
 
 MODCLEAN = $(addsuffix .clean, $(MODULES))
 
diff --git a/datasketches-cpp b/datasketches-cpp

Original file line number	Diff line number	Diff line change
`@@ -1,3 +0,0 @@`
`1`		`-[submodule "datasketches-cpp"]`
`2`		`- path = datasketches-cpp`
`3`		`- url = https://github.com/apache/datasketches-cpp`