Merge pull request #141 from proost/fix-grow-to-cap

proost · web-flow · commit 97bb82599bc4 · 2026-03-25T10:30:52.000+09:00
fix: grow cap
diff --git a/sampling/reservoir_items_sketch.go b/sampling/reservoir_items_sketch.go
@@ -132,7 +132,7 @@ func (s *ReservoirItemsSketch[T]) Update(item T) error {
 
 func (s *ReservoirItemsSketch[T]) growReservoir() {
 	adjustedSize := adjustedSamplingAllocationSize(s.k, cap(s.data)<<int(s.rf))
-	s.data = slices.Grow(s.data, adjustedSize-cap(s.data))
+	s.data = slices.Grow(s.data, adjustedSize)
 }
 
 // K returns the maximum reservoir capacity.
@@ -483,7 +483,7 @@ func NewReservoirItemsSketchFromSlice[T any](data []byte, serde ItemsSerDe[T]) (
 		return nil, err
 	}
 
-	sketch.data = slices.Grow(sketch.data, capacity-cap(sketch.data))
+	sketch.data = slices.Grow(sketch.data, capacity)
 
 	return &ReservoirItemsSketch[T]{
 		k:    k,

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ func (s *ReservoirItemsSketch[T]) Update(item T) error {`
`132`	`132`
`133`	`133`	`func (s *ReservoirItemsSketch[T]) growReservoir() {`
`134`	`134`	`adjustedSize := adjustedSamplingAllocationSize(s.k, cap(s.data)<<int(s.rf))`
`135`		`- s.data = slices.Grow(s.data, adjustedSize-cap(s.data))`
	`135`	`+ s.data = slices.Grow(s.data, adjustedSize)`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`// K returns the maximum reservoir capacity.`
`@@ -483,7 +483,7 @@ func NewReservoirItemsSketchFromSlice[T any](data []byte, serde ItemsSerDe[T]) (`
`483`	`483`	`return nil, err`
`484`	`484`	`}`
`485`	`485`
`486`		`- sketch.data = slices.Grow(sketch.data, capacity-cap(sketch.data))`
	`486`	`+ sketch.data = slices.Grow(sketch.data, capacity)`
`487`	`487`
`488`	`488`	`return &ReservoirItemsSketch[T]{`
`489`	`489`	`k: k,`