Skip to content

Commit 007f35b

Browse files
authored
Merge pull request #476 from apache/test_flow_changes
use serialization_test_data instead of target2 for cross-repo test data
2 parents fcded46 + c8ee3bb commit 007f35b

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/check_cpp_files.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ jobs:
2525
- name: Run C++ tests
2626
run: cd cpp && cmake --build build --config Release --target test
2727
- name: Make dir
28-
run: mkdir -p target/cpp_generated_files
28+
run: mkdir -p serialization_test_data/cpp_generated_files
2929
- name: Copy files
30-
run: cp cpp/build/*/test/*_cpp.sk target/cpp_generated_files
30+
run: cp cpp/build/*/test/*_cpp.sk serialization_test_data/cpp_generated_files
3131
- name: Run Java tests
3232
run: mvn test -P check-cpp-files

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ tmp/
4949

5050
# Build artifacts
5151
target/
52-
target2/
52+
serialization_test_data/
5353
out/
5454
build/
5555
jarsIn/

src/test/java/org/apache/datasketches/common/TestUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ public final class TestUtil {
5252
/**
5353
* The full target Path for Java serialized sketches to be tested by other languages.
5454
*/
55-
public static final Path javaPath = createPath("target2/java_generated_files");
55+
public static final Path javaPath = createPath("serialization_test_data/java_generated_files");
5656

5757
/**
5858
* The full target Path for C++ serialized sketches to be tested by Java.
5959
*/
60-
public static final Path cppPath = createPath("target2/cpp_generated_files");
60+
public static final Path cppPath = createPath("serialization_test_data/cpp_generated_files");
6161

6262
private static Path createPath(final String projectLocalDir) {
6363
try {

0 commit comments

Comments
 (0)