@@ -95,40 +95,42 @@ under the License.
9595 <!-- System-wide properties -->
9696 <maven .version>3.6.3</maven .version>
9797 <java .version>17</java .version>
98+ <add-modules >--add-modules=jdk.incubator.foreign</add-modules >
9899 <maven .compiler.source>${java.version} </maven .compiler.source>
99100 <maven .compiler.target>${java.version} </maven .compiler.target>
100- <argLine >-Xmx4g -Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8 -- add-modules=jdk.incubator.foreign </argLine >
101+ <argLine >-Xmx4g -Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8 ${ add-modules} </argLine >
101102 <charset .encoding>UTF-8</charset .encoding>
102103 <project .build.sourceEncoding>${charset.encoding} </project .build.sourceEncoding>
103104 <project .build.resourceEncoding>${charset.encoding} </project .build.resourceEncoding>
104105 <project .reporting.outputEncoding>${charset.encoding} </project .reporting.outputEncoding>
105106 <maven .build.timestamp.format>yyyy-MM-dd'T'HH-mm-ss'Z'</maven .build.timestamp.format>
106107
107108 <!-- org.apache.maven plugins -->
108- <maven-assembly-plugin .version>3.7.1</maven-assembly-plugin .version>
109- <maven-compiler-plugin .version>3.13.0</maven-compiler-plugin .version>
110- <maven-deploy-plugin .version>3.1.3</maven-deploy-plugin .version>
111- <maven-enforcer-plugin .version>3.5.0</maven-enforcer-plugin .version>
112- <maven-gpg-plugin .version>3.2.5</maven-gpg-plugin .version>
113- <maven-jar-plugin .version>3.4.2</maven-jar-plugin .version>
114- <maven-javadoc-plugin .version>3.8.0</maven-javadoc-plugin .version>
115- <maven-release-plugin .version>3.1.1</maven-release-plugin .version>
116- <maven-remote-resources-plugin .version>3.2.0</maven-remote-resources-plugin .version>
117- <maven-source-plugin .version>3.3.1</maven-source-plugin .version>
118- <maven-surefire-failsafe-plugins .version>3.4.0</maven-surefire-failsafe-plugins .version> <!-- for surefire, failsafe and surefire-report-->
119- <!-- com.github plugins -->
120- <git-commit-id-plugin .version>4.9.10</git-commit-id-plugin .version>
121- <!-- org.apache.creadur plugins -->
122- <apache-rat-plugin .version>0.16.1</apache-rat-plugin .version>
123- <!-- org.eluder maven plugins -->
124- <coveralls-repo-token ></coveralls-repo-token >
125- <coveralls-maven-plugin .version>4.3.0</coveralls-maven-plugin .version>
126- <!-- org.jacoco maven plugins -->
127- <jacoco-maven-plugin .version>0.8.12</jacoco-maven-plugin .version>
128- <!-- org.mojohaus plugins -->
129- <versions-maven-plugin .version>2.17.1</versions-maven-plugin .version>
130- <!-- other -->
131- <lifecycle-mapping .version>1.0.0</lifecycle-mapping .version>
109+ <maven-assembly-plugin .version>3.7.1</maven-assembly-plugin .version>
110+ <maven-compiler-plugin .version>3.13.0</maven-compiler-plugin .version>
111+ <maven-deploy-plugin .version>3.1.3</maven-deploy-plugin .version>
112+ <maven-enforcer-plugin .version>3.5.0</maven-enforcer-plugin .version>
113+ <maven-gpg-plugin .version>3.2.7</maven-gpg-plugin .version>
114+ <maven-jar-plugin .version>3.4.2</maven-jar-plugin .version>
115+ <maven-javadoc-plugin .version>3.11.1</maven-javadoc-plugin .version>
116+ <maven-release-plugin .version>3.1.1</maven-release-plugin .version>
117+ <maven-remote-resources-plugin .version>3.2.0</maven-remote-resources-plugin .version>
118+ <maven-source-plugin .version>3.3.1</maven-source-plugin .version>
119+ <maven-surefire-failsafe-plugins .version>3.5.2</maven-surefire-failsafe-plugins .version> <!-- for surefire, failsafe and surefire-report -->
120+ <maven-toolchains-plugin .version>3.2.0</maven-toolchains-plugin .version>
121+ <!-- com.github plugins -->
122+ <git-commit-id-plugin .version>4.9.10</git-commit-id-plugin .version>
123+ <!-- org.apache.creadur plugins -->
124+ <apache-rat-plugin .version>0.16.1</apache-rat-plugin .version>
125+ <!-- org.eluder maven plugins -->
126+ <coveralls-repo-token ></coveralls-repo-token >
127+ <coveralls-maven-plugin .version>4.3.0</coveralls-maven-plugin .version>
128+ <!-- org.jacoco.maven plugins -->
129+ <jacoco-maven-plugin .version>0.8.12</jacoco-maven-plugin .version>
130+ <!-- org.mojohaus plugins -->
131+ <versions-maven-plugin .version>2.17.1</versions-maven-plugin .version>
132+ <!-- other -->
133+ <lifecycle-mapping .version>1.0.0</lifecycle-mapping .version>
132134 </properties >
133135
134136 <dependencies >
@@ -145,13 +147,6 @@ under the License.
145147 <version >${testng.version} </version >
146148 <scope >test</scope >
147149 </dependency >
148- <!--
149- <dependency>
150- <groupId>org.apache.datasketches</groupId>
151- <artifactId>datasketches-java-common</artifactId>
152- <version>1.0.0</version>
153- </dependency>
154- -->
155150 </dependencies >
156151
157152 <build >
@@ -169,7 +164,7 @@ under the License.
169164 <version >${maven-compiler-plugin.version} </version >
170165 <configuration >
171166 <compilerArgs >
172- <arg >-- add-modules=jdk.incubator.foreign </arg >
167+ <arg >${ add-modules} </arg >
173168 </compilerArgs >
174169 </configuration >
175170 </plugin >
@@ -195,10 +190,10 @@ under the License.
195190 <configuration >
196191 <rules >
197192 <requireJavaVersion >
198- <version >[17,18) </version >
193+ <version >${java.version} </version >
199194 </requireJavaVersion >
200195 <requireMavenVersion >
201- <version >[${maven.version} ,)</version >
196+ <version >[${maven.version} ,4.0.0 )</version >
202197 </requireMavenVersion >
203198 <bannedDependencies >
204199 <excludes >
@@ -243,7 +238,7 @@ under the License.
243238 <docfilessubdirs >true</docfilessubdirs >
244239 <show >public</show >
245240 <additionalOptions >
246- <additionalOption >-- add-modules=jdk.incubator.foreign </additionalOption >
241+ <additionalOption >${ add-modules} </additionalOption >
247242 </additionalOptions >
248243 </configuration >
249244 <executions >
@@ -289,7 +284,7 @@ under the License.
289284 <artifactId >maven-surefire-plugin</artifactId >
290285 <version >${maven-surefire-failsafe-plugins.version} </version >
291286 <configuration >
292- <argLine >-- add-modules=jdk.incubator.foreign </argLine >
287+ <argLine >${ add-modules} </argLine >
293288 <trimStackTrace >false</trimStackTrace >
294289 <useManifestOnlyJar >false</useManifestOnlyJar >
295290 <redirectTestOutputToFile >true</redirectTestOutputToFile >
@@ -298,6 +293,26 @@ under the License.
298293 </configuration >
299294 </plugin >
300295
296+ <plugin >
297+ <groupId >org.apache.maven.plugins</groupId >
298+ <artifactId >maven-toolchains-plugin</artifactId >
299+ <version >${maven-toolchains-plugin.version} </version >
300+ <executions >
301+ <execution >
302+ <goals >
303+ <goal >toolchain</goal >
304+ </goals >
305+ </execution >
306+ </executions >
307+ <configuration >
308+ <toolchains >
309+ <jdk >
310+ <version >${java.version} </version >
311+ </jdk >
312+ </toolchains >
313+ </configuration >
314+ </plugin >
315+
301316 <plugin >
302317 <groupId >org.apache.rat</groupId >
303318 <artifactId >apache-rat-plugin</artifactId >
@@ -402,6 +417,10 @@ under the License.
402417 <groupId >org.apache.maven.plugins</groupId >
403418 <artifactId >maven-surefire-plugin</artifactId >
404419 </plugin >
420+ <plugin >
421+ <groupId >org.apache.maven.plugins</groupId >
422+ <artifactId >maven-toolchains-plugin</artifactId >
423+ </plugin >
405424 <plugin >
406425 <groupId >org.apache.rat</groupId >
407426 <artifactId >apache-rat-plugin</artifactId >
0 commit comments