Revert "Fix some SpotBugs issues."

This reverts commit 98fd833.

Author: leerho

src/main/java/org/apache/datasketches/common/Util.java

@@ -767,7 +767,7 @@ public static int numDigits(int n) {
    * @return the given number to a string prepended with spaces
    */
   public static String intToFixedLengthString(final int number, final int length) {
-    final String num = Integer.toString(number);
+    final String num = Integer.valueOf(number).toString();
     return characterPad(num, length, ' ', false);
   }
 

src/main/java/org/apache/datasketches/kll/KllItemsSketch.java

@@ -243,7 +243,7 @@ public double[] getRanks(final T[] quantiles, final QuantileSearchCriteria searc
   public KllItemsSketchSortedView<T> getSortedView() {
     if (isEmpty()) { throw new SketchesArgumentException(EMPTY_MSG); }
     refreshSortedView();
-    return new KllItemsSketchSortedView<T>(kllItemsSV);
+    return kllItemsSV;
   }
 
   @Override

src/main/java/org/apache/datasketches/kll/KllItemsSketchSortedView.java

@@ -66,25 +66,13 @@ public KllItemsSketchSortedView(
       final long totalN,
       final T minItem,
       final Comparator<? super T> comparator) {
-    this.quantiles = quantiles.clone();
-    this.cumWeights  = cumWeights.clone();
+    this.quantiles = quantiles;
+    this.cumWeights  = cumWeights;
     this.totalN = totalN;
     this.minItem = minItem;
     this.comp = comparator;
   }
 
-  /**
-   * Copy constructor.
-   * @param sv the given Sorted View
-   */
-  public KllItemsSketchSortedView(final KllItemsSketchSortedView<T> sv) {
-    this.quantiles = sv.quantiles.clone();
-    this.cumWeights = sv.cumWeights.clone();
-    this.totalN = sv.totalN;
-    this.minItem = sv.minItem;
-    this.comp = sv.comp;
-  }
-
   /**
    * Constructs this Sorted View given the sketch
    * @param sk the given KllItemsSketch.

src/main/java/org/apache/datasketches/quantilescommon/GenericSortedViewIterator.java

@@ -35,8 +35,8 @@ public class GenericSortedViewIterator<T> implements SortedViewIterator {
   private int index;
 
   public GenericSortedViewIterator(final T[] quantiles, final long[] cumWeights) {
-    this.quantiles = quantiles.clone();
-    this.cumWeights = cumWeights.clone();
+    this.quantiles = quantiles;
+    this.cumWeights = cumWeights;
     this.totalN = (cumWeights.length > 0) ? cumWeights[cumWeights.length - 1] : 0;
     index = -1;
   }

src/test/java/org/apache/datasketches/common/TestUtil.java

@@ -29,7 +29,7 @@
  */
 public final class TestUtil  {
 
-  private static final String userDir = System.getProperty("user.dir");
+  private static String userDir = System.getProperty("user.dir");
 
   /**
    * TestNG group constants
@@ -41,17 +41,17 @@ public final class TestUtil  {
   /**
    * The full target Path for Java serialized sketches to be tested by other languages.
    */
-  public static final Path javaPath = createPath("target/java_generated_files");
+  public static Path javaPath = createPath("target/java_generated_files");
 
   /**
    * The full target Path for C++ serialized sketches to be tested by Java.
    */
-  public static final Path cppPath = createPath("target/cpp_generated_files");
+  public static Path cppPath = createPath("target/cpp_generated_files");
 
   /**
    * The full target Path for historical C++ serialized sketches to be tested by Java.
    */
-  public static final Path cppHistPath = createPath("src/test/resources");
+  public static Path cppHistPath = createPath("src/test/resources");
 
   private static Path createPath(final String projectLocalDir) {
     try {

src/test/java/org/apache/datasketches/kll/KllCrossLanguageTest.java

@@ -154,14 +154,14 @@ public void kllDouble() throws IOException {
 
   @Test(groups = {CHECK_CPP_FILES})
   public void kllString() throws IOException {
-    // the sketch under test intentionally contains numbers in strings to make meaningful assertions
+    // sketch contains numbers in strings to make meaningful assertions
     Comparator<String> numericOrder = new Comparator<String>() {
       @Override
       public int compare(final String s1, final String s2) {
         try {
           final int i1 = Integer.parseInt(s1);
           final int i2 = Integer.parseInt(s2);
-          return Integer.compare(i1, i2);
+          return Integer.valueOf(i1).compareTo(i2);
         } catch (NumberFormatException e) {
           throw new RuntimeException(e);
         }

src/test/java/org/apache/datasketches/quantiles/QuantilesSketchCrossLanguageTest.java

@@ -68,7 +68,7 @@ public int compare(final String s1, final String s2) {
           try {
             final int i1 = Integer.parseInt(s1);
             final int i2 = Integer.parseInt(s2);
-            return Integer.compare(i1, i2);
+            return Integer.valueOf(i1).compareTo(i2);
           } catch (NumberFormatException e) {
             throw new RuntimeException(e);
           }
@@ -117,7 +117,7 @@ public int compare(final String s1, final String s2) {
         try {
           final int i1 = Integer.parseInt(s1);
           final int i2 = Integer.parseInt(s2);
-          return Integer.compare(i1, i2);
+          return Integer.valueOf(i1).compareTo(i2);
         } catch (NumberFormatException e) {
           throw new RuntimeException(e);
         }

src/test/java/org/apache/datasketches/req/ReqSketchCrossLanguageTest.java

@@ -28,6 +28,7 @@
 
 import java.io.IOException;
 import java.nio.file.Files;
+import java.util.Comparator;
 
 import org.apache.datasketches.memory.Memory;
 import org.apache.datasketches.quantilescommon.QuantilesFloatsSketchIterator;

tools/FindBugsExcludeFilter.xml

@@ -40,14 +40,8 @@ under the License.
   </Match>
 
   <!-- Harmless, Too many False Positives May 2, 2023 -->
-  <Match>
+  <Match>   
     <Bug pattern="DLS_DEAD_LOCAL_STORE" />
   </Match>
-  
-  <!-- This is test utility class -->
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP2" />
-    <Class name="org.apache.datasketches.req.ReqDebugImpl" />
-  </Match>
 
 </FindBugsFilter>