Skip to content

Commit 9c486a5

Browse files
authored
Merge pull request #663 from apache/update_8.0.X
Remove exclusions from FindBugsExcludeFilter.xml
2 parents 3eaa9cf + 45bb98d commit 9c486a5

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

tools/FindBugsExcludeFilter.xml

+4-13
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,6 @@ under the License.
2424
<Match>
2525
<Class name="~.*\.*Test" />
2626
</Match>
27-
28-
<Match>
29-
<Class name="~.*\.*TestUtil" />
30-
</Match>
31-
32-
<!-- Harmless, False Positive Mar 6, 2024. Alex may fix this. -->
33-
<Match>
34-
<Bug pattern="DLS_DEAD_LOCAL_STORE" />
35-
<Class name="org.apache.datasketches.tdigest.TDigestDouble"/>
36-
<Method name="merge" />
37-
</Match>
3827

3928
<!-- Complaining about copying of arrays from one internal class to another.
4029
This is harmless since both classes are part of our library and work together. -->
@@ -49,7 +38,8 @@ under the License.
4938
</Or>
5039
</Match>
5140

52-
<Match> <!-- False Positive: These are intentional and we know what we are doing. -->
41+
<!-- False Positive: These are intentional and we know what we are doing. -->
42+
<Match>
5343
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
5444
<Class name="org.apache.datasketches.sampling.EbppsItemsSample" />
5545
<Or>
@@ -58,7 +48,8 @@ under the License.
5848
</Or>
5949
</Match>
6050

61-
<Match> <!-- False Positive: Code is the recommended solution for preventing a Finalizer Attack. -->
51+
<!-- False Positive: Code is the recommended solution for preventing a Finalizer Attack. -->
52+
<Match>
6253
<Bug pattern="CT_CONSTRUCTOR_THROW" />
6354
<Or>
6455
<Class name="org.apache.datasketches.tuple.arrayofdoubles.DirectArrayOfDoublesQuickSelectSketch"/>

0 commit comments

Comments
 (0)