Fix headers in xml files.

Author: leerho

src/test/java/org/apache/datasketches/common/TestUtil.java

@@ -133,7 +133,8 @@ public static void putBytesToFile(final Path basePath, final String fileName, fi
       filePath = basePath.resolve(fileName);
       Files.write(filePath, bytes);
     } catch (IOException e) {
-      throw new RuntimeException("System IO Error writing file: " + filePath.toString() + " " + e);
+      final String filePathDesc = String.valueOf(filePath);
+      throw new RuntimeException("System IO Error writing file: " + filePathDesc + " " + e);
     }
   }
 }

tools/SketchesCheckstyle.xml

@@ -1,7 +1,4 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE module PUBLIC
-    "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
-    "https://checkstyle.org/dtds/configuration_1_3.dtd">
 
 <!--
 Licensed to the Apache Software Foundation (ASF) under one
@@ -38,7 +35,7 @@ under the License.
   <property name="fileExtensions" value="java"/>
   <property name="basedir" value="${basedir}"/>
 
-  <!-- Exclude all module-info.java files 
+  <!-- Exclude all module-info.java files
        https://checkstyle.org/filefilters/beforeexecutionexclusionfilefilter.html#BeforeExecutionExclusionFileFilter -->
   <module name="BeforeExecutionExclusionFileFilter">
     <property name="fileNamePattern" value="module\-info\.java$"/>
@@ -53,31 +50,31 @@ under the License.
   <module name="FileTabCharacter">
     <property name="fileExtensions" value="java, xml, yml, yaml"/>
   </module>
-  
+
   <!-- each package must have a package-info.java file -->
   <module name="JavadocPackage"/>
-  
+
   <module name="NewlineAtEndOfFile">
     <property name="lineSeparator" value="lf"/>
   </module>
-  
+
   <!-- Size Violations -->
   <module name="LineLength">
     <property name="severity" value="warning"/>
     <property name="max" value="140"/>
     <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
     <!-- <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> -->
   </module>
-  
+
   <!-- Filters -->
   <module name="SuppressWithPlainTextCommentFilter">
     <property name="offCommentFormat" value="//CHECKSTYLE.OFF\: ([\w\|]+)"/>
     <property name="onCommentFormat" value="//CHECKSTYLE.ON\: ([\w\|]+)"/>
     <property name="checkFormat" value="$1"/>
   </module>
-  
+
   <!-- ******************************************************** -->
-  
+
   <module name="TreeWalker">
 
     <!-- Be able to ignore violations with @SuppressWarnings -->
@@ -88,7 +85,7 @@ under the License.
     <module name="AnnotationLocation">
       <property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF"/>
     </module>
-    
+
     <module name="AnnotationLocation">
       <property name="tokens" value="VARIABLE_DEF"/>
       <property name="allowSamelineMultipleAnnotations" value="true"/>
@@ -101,108 +98,108 @@ under the License.
       <property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="EmptyCatchBlock">
       <property name="severity" value="ignore"/>
       <property name="exceptionVariableName" value="expected"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="LeftCurly">
       <!-- doesn't allow for if (n == 0) { return 0.0; }, which is readable and not corruptable -->
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="NeedBraces">
       <property name="allowSingleLineStatement" value="false"/> <!-- default = false -->
       <property name="allowEmptyLoopBody" value="false"/>       <!-- default = false -->
     </module>
-    
-    <module name="RightCurly"> 
+
+    <module name="RightCurly">
       <!-- requires right curly start a new line; alone: on a line alone -->
       <property name="severity" value="ignore"/>
       <property name="option" value="alone"/>
       <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <!-- Coding -->
     <module name="FallThrough">
       <property name="severity" value="warning"/>
       <property name="reliefPattern" value="fallthru|falls? ?through|FALL[- ]?THROUGH"/>
       <!-- <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> -->
     </module>
-    
+
     <module name="FinalLocalVariable">
       <property name="severity" value="warning"/>
       <property name="tokens" value="VARIABLE_DEF,PARAMETER_DEF"/>
     </module>
-    
+
     <module name="IllegalTokenText">
       <property name="severity" value="warning"/>
       <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
       <property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
       <property name="message" value="Avoid using corresponding octal or Unicode escape."/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="MissingSwitchDefault">
       <!-- Too many false positives -->
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="MultipleVariableDeclarations">
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="NoFinalizer">
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="OneStatementPerLine">
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="OverloadMethodsDeclarationOrder">
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="VariableDeclarationUsageDistance">
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="IllegalTokenText">
       <property name="tokens" value="STRING_LITERAL"/>
       <property name="format" value="\\n"/>
     </module>
-    
+
     <!-- Class Design -->
     <module name="OneTopLevelClass"/>
-    
+
     <module name="FinalClass"/>
-    
+
     <!-- Imports -->
     <module name="AvoidStarImport"/>
-    
+
     <module name="CustomImportOrder">
       <property name="specialImportsRegExp" value="org"/>
       <property name="sortImportsInGroupAlphabetically" value="false"/>
       <property name="separateLineBetweenGroups" value="true"/>
       <!-- Google: "STATIC###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE" -->
       <property name="customImportOrderRules" value="STATIC###STANDARD_JAVA_PACKAGE###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE"/>
     </module>
-    
+
     <module name="RedundantImport"/>
-    
+
     <module name="UnusedImports"/>
-    
+
     <!-- Filters -->
     <!-- Enable suppression using comments: //CHECKSTYLE.OFF: "RULE" and //CHECKSTYLE.ON: "RULE"
      You must specify the specific rule, as in: //CHECKSTYLE.OFF: LineLength -->
@@ -211,41 +208,41 @@ under the License.
       <property name="onCommentFormat" value="//CHECKSTYLE.ON\: ([\w\|]+)"/>
       <property name="checkFormat" value="$1"/>
     </module>
-    
+
     <!-- Javadoc Comments -->
     <!-- JavadocPackage under Checker -->
     <module name="AtclauseOrder">
       <property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
       <property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
     </module>
-    
+
     <module name="JavadocMethod">
       <property name="accessModifiers" value="public"/>
       <property name="allowMissingParamTags" value="false"/> <!-- default -->
       <property name="allowMissingReturnTag" value="false"/> <!-- default -->
       <property name="allowedAnnotations" value="Override, Test"/>
     </module>
-    
+
     <!-- disabled because of a Checkstyle bug with <p> after @param -->
     <!-- <module name="JavadocParagraph"/>  -->
 
     <module name="JavadocTagContinuationIndentation">
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-        
+
     <module name="NonEmptyAtclauseDescription"/>
-    
+
     <module name="SingleLineJavadoc">
       <property name="ignoreInlineTags" value="false"/>
     </module>
-    
+
     <module name="SummaryJavadocCheck">
       <property name="severity" value="ignore"/>
       <property name="forbiddenSummaryFragments" value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <!-- Miscellaneous -->
     <module name="ArrayTypeStyle">
       <property name="severity" value="ignore"/>
@@ -259,12 +256,12 @@ under the License.
       <property name="allowNonPrintableEscapes" value="true"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="CommentsIndentation">
       <property name="severity" value="ignore"/>
       <!-- <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> -->
     </module>
-    
+
     <module name="Indentation">
       <property name="severity" value="ignore"/>
       <property name="basicOffset" value="2"/>
@@ -275,27 +272,27 @@ under the License.
       <property name="arrayInitIndent" value="2"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="OuterTypeFilename">
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <module name="TodoComment">
       <property name="severity" value="ignore"/>
       <property name="format" value="(//TODO)|(//FIXME)"/>
     </module>
-    
+
     <module name="UpperEll">
       <property name="severity" value="warning"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <!-- Modifiers -->
     <module name="ModifierOrder">
       <property name="severity" value="ignore"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
-    
+
     <!-- Naming Conventions -->
     <module name="AbbreviationAsWordInName">
       <property name="severity" value="ignore"/>
@@ -369,13 +366,13 @@ under the License.
       <property name="message" value="Trailing whitespace"/>
       <property name="ignoreComments" value="true"/>
     </module>
-    
+
     <!-- Whitespace -->
     <module name="EmptyLineSeparator">
       <property name="allowNoEmptyLineBetweenFields" value="true"/>
       <property name="allowMultipleEmptyLines" value="false"/>
     </module>
-    
+
     <module name="GenericWhitespace">
       <message key="ws.followed"
           value="GenericWhitespace ''{0}'' is followed by whitespace."/>
@@ -386,26 +383,26 @@ under the License.
       <message key="ws.notPreceded"
           value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>
     </module>
-    
+
     <module name="NoLineWrap"/> <!-- Only for import and package statements -->
-    
+
     <module name="MethodParamPad"/>
-    
+
     <module name="OperatorWrap">
       <property name="option" value="NL"/>
       <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
     </module>
-    
+
     <module name="SeparatorWrap">
       <property name="tokens" value="DOT"/>
       <property name="option" value="nl"/>
     </module>
-    
+
     <module name="SeparatorWrap">
       <property name="tokens" value="COMMA"/>
       <property name="option" value="EOL"/>
     </module>
-    
+
     <module name="WhitespaceAround">
       <property name="allowEmptyConstructors" value="true"/>
       <property name="allowEmptyMethods" value="true"/>