Skip to content

Commit be4646f

Browse files
committed
fix: init with Inf
1 parent d67731a commit be4646f

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

src/main/java/org/apache/datasketches/req/ReqSerDe.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,15 @@
1919

2020
package org.apache.datasketches.req;
2121

22-
import static java.lang.Math.max;
23-
import static java.lang.Math.round;
24-
2522
import java.lang.foreign.MemorySegment;
2623
import java.util.ArrayList;
2724
import java.util.List;
2825

2926
import org.apache.datasketches.common.Family;
3027
import org.apache.datasketches.common.positional.PositionalSegment;
3128

29+
import static java.lang.Math.*;
30+
3231
/**
3332
* This class handles serialization and deserialization.
3433
*
@@ -203,17 +202,16 @@ static final Compactor extractCompactor(final PositionalSegment posSeg, final bo
203202
final int count = posSeg.getInt();
204203
final float[] arr = new float[count];
205204
posSeg.getFloatArray(arr, 0, count);
206-
float minItem = Float.NaN;
207-
float maxItem = Float.NaN;
205+
float minItem = Float.POSITIVE_INFINITY;
206+
float maxItem = Float.NEGATIVE_INFINITY;
208207
for (int i = 0; i < count; i++) {
209208
final float item = arr[i];
210-
if (Float.isNaN(minItem)) {
211-
minItem = item;
212-
maxItem = item;
213-
} else {
214-
if (item < minItem) { minItem = item; }
215-
if (item > maxItem) { maxItem = item; }
209+
if (Float.isNaN(item)) {
210+
continue;
216211
}
212+
213+
minItem = min(minItem, arr[i]);
214+
maxItem = max(maxItem, arr[i]);
217215
}
218216
final int delta = 2 * sectionSize * numSections;
219217
final int nomCap = 2 * delta;

0 commit comments

Comments
 (0)