Skip to content

Commit c91c2a6

Browse files
leerhojmalkin
authored andcommitted
While reviewing these changes again, I found some commented out lines
that could be removed and some unnecessary minor changes that could be reverted.
1 parent f268943 commit c91c2a6

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

src/main/java/org/apache/datasketches/quantiles/ItemsSketchSortedView.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,9 @@
2626
import static org.apache.datasketches.quantilescommon.QuantilesUtil.getNaturalRank;
2727

2828
import java.lang.reflect.Array;
29-
//import java.util.Arrays;
3029
import java.util.Comparator;
3130

3231
import org.apache.datasketches.common.SketchesArgumentException;
33-
//import org.apache.datasketches.common.SketchesStateException;
3432
import org.apache.datasketches.quantilescommon.GenericInequalitySearch.Inequality;
3533
import org.apache.datasketches.quantilescommon.GenericPartitionBoundaries;
3634
import org.apache.datasketches.quantilescommon.GenericSortedView;

src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,11 @@ private QuickSelectSketch(
170170
* @param mem Memory object with serialized QuickSelectSketch
171171
* @param deserializer the SummaryDeserializer
172172
* @param summaryFactory the SummaryFactory
173+
* @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated.
173174
* This capability will be removed in a future release.
174175
* Heapifying a CompactSketch is not deprecated.
175176
*/
177+
@Deprecated
176178
QuickSelectSketch(
177179
final Memory mem,
178180
final SummaryDeserializer<S> deserializer,

src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesQuickSelectSketch.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ abstract class ArrayOfDoublesQuickSelectSketch extends ArrayOfDoublesUpdatableSk
5757
int rebuildThreshold_; //absolute value relative to current capacity
5858
int lgCurrentCapacity_;
5959

60-
ArrayOfDoublesQuickSelectSketch(
61-
final int numValues,
62-
final long seed) {
60+
ArrayOfDoublesQuickSelectSketch(final int numValues, final long seed) {
6361
super(numValues, seed);
6462
}
6563

0 commit comments

Comments
 (0)