Skip to content

Commit d70f391

Browse files
authored
Merge pull request #273 from apache/sampling_cleanup
remove unused, commented-out code
2 parents 2994201 + c75d1a2 commit d70f391

2 files changed

Lines changed: 0 additions & 111 deletions

File tree

src/test/java/com/yahoo/sketches/sampling/ReservoirItemsSketchTest.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -413,28 +413,6 @@ public void checkSampleWeight() {
413413
assertTrue((ris.getImplicitSampleWeight() - 1.5) < EPS);
414414
}
415415

416-
/*
417-
@Test
418-
public void checkReadOnlyHeapify() {
419-
final ArrayOfLongsSerDe serDe = new ArrayOfLongsSerDe();
420-
Memory sketchMem = getBasicSerializedLongsRIS();
421-
422-
// Load from read-only and writable memory to ensure they deserialize identically
423-
ReservoirItemsSketch<Long> ris = ReservoirItemsSketch.heapify(sketchMem.asReadOnlyMemory(),
424-
serDe);
425-
ReservoirItemsSketch<Long> fromWritable = ReservoirItemsSketch.heapify(sketchMem, serDe);
426-
validateReservoirEquality(ris, fromWritable);
427-
428-
// Same with an empty sketch
429-
final byte[] sketchBytes = ReservoirItemsSketch.<Long>newInstance(32).toByteArray(serDe);
430-
sketchMem = new NativeMemory(sketchBytes);
431-
432-
ris = ReservoirItemsSketch.heapify(sketchMem.asReadOnlyMemory(), serDe);
433-
fromWritable = ReservoirItemsSketch.heapify(sketchMem, serDe);
434-
validateReservoirEquality(ris, fromWritable);
435-
}
436-
*/
437-
438416
@Test
439417
public void checkVersionConversion() {
440418
// version change from 1 to 2 only impact first preamble long, so empty sketch is sufficient

src/test/java/com/yahoo/sketches/sampling/VersionConverterTest.java

Lines changed: 0 additions & 89 deletions
This file was deleted.

0 commit comments

Comments
 (0)