Skip to content

Commit e581262

Browse files
author
Lee Rhodes
committed
Merge branch 'master' into MemoryMapped-force
2 parents 1c8beab + 7a7d886 commit e581262

2 files changed

Lines changed: 150 additions & 50 deletions

File tree

src/main/java/com/yahoo/sketches/theta/DirectQuickSelectSketch.java

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ private DirectQuickSelectSketch(int lgNomLongs, long seed, float p, ResizeFactor
9595
*
9696
* @param lgNomLongs <a href="{@docRoot}/resources/dictionary.html#lgNomLongs">See lgNomLongs</a>.
9797
* @param seed <a href="{@docRoot}/resources/dictionary.html#seed">See Update Hash Seed</a>.
98-
* @param p <a href="{@docRoot}/resources/dictionary.html#p">See Sampling Probability, <i>p</i></a>
98+
* @param p
99+
* <a href="{@docRoot}/resources/dictionary.html#p">See Sampling Probability, <i>p</i></a>
99100
* @param rf Currently internally fixed at 2. Unless dstMem is not configured with a valid
100101
* MemoryRequest, in which case the rf is effectively 1, which is no resizing at all and the
101102
* dstMem must be large enough for a full sketch.
@@ -156,7 +157,8 @@ static DirectQuickSelectSketch getInstance(int lgNomLongs, long seed, float p, R
156157
//clear hash table area
157158
dstMem.clear(preambleLongs << 3, 8 << lgArrLongs);
158159

159-
DirectQuickSelectSketch dqss = new DirectQuickSelectSketch(lgNomLongs, seed, p, rf, preambleLongs);
160+
DirectQuickSelectSketch dqss =
161+
new DirectQuickSelectSketch(lgNomLongs, seed, p, rf, preambleLongs);
160162
dqss.lgArrLongs_ = lgArrLongs;
161163
dqss.hashTableThreshold_ = setHashTableThreshold(lgNomLongs, lgArrLongs);
162164
dqss.curCount_ = curCount;
@@ -219,10 +221,11 @@ else if (family.equals(Family.QUICKSELECT)) {
219221
+ lgNomLongs + " < " + MIN_LG_NOM_LONGS);
220222
}
221223

222-
int flagsMask = ORDERED_FLAG_MASK | COMPACT_FLAG_MASK | READ_ONLY_FLAG_MASK | BIG_ENDIAN_FLAG_MASK;
224+
int flagsMask =
225+
ORDERED_FLAG_MASK | COMPACT_FLAG_MASK | READ_ONLY_FLAG_MASK | BIG_ENDIAN_FLAG_MASK;
223226
if ((flags & flagsMask) > 0) {
224227
throw new SketchesArgumentException(
225-
"Possible corruption: Input srcMem cannot be: big-endian, compact, ordered, or read-only");
228+
"Possible corruption: Input srcMem cannot be: big-endian, compact, ordered, or read-only");
226229
}
227230

228231
Util.checkSeedHashes(seedHash, Util.computeSeedHash(seed));
@@ -242,7 +245,8 @@ else if (family.equals(Family.QUICKSELECT)) {
242245
+ lgArrLongs + " <= " + lgNomLongs + ", Theta: " + theta + ", p: " + p);
243246
}
244247

245-
DirectQuickSelectSketch dqss = new DirectQuickSelectSketch(lgNomLongs, seed, p, myRF, preambleLongs);
248+
DirectQuickSelectSketch dqss =
249+
new DirectQuickSelectSketch(lgNomLongs, seed, p, myRF, preambleLongs);
246250
dqss.lgArrLongs_ = lgArrLongs;
247251
dqss.hashTableThreshold_ = setHashTableThreshold(lgNomLongs, lgArrLongs);
248252
dqss.curCount_ = curCount;
@@ -370,7 +374,8 @@ UpdateReturnState hashUpdate(long hash) {
370374

371375
if (lgArrLongs_ > lgNomLongs_) { //at full size, rebuild
372376
//Assumes no dirty values, changes thetaLong_, curCount_
373-
assert (lgArrLongs_ == lgNomLongs_ + 1) : "lgArr: " + lgArrLongs_ + ", lgNom: " + lgNomLongs_;
377+
assert
378+
(lgArrLongs_ == lgNomLongs_ + 1) : "lgArr: " + lgArrLongs_ + ", lgNom: " + lgNomLongs_;
374379
quickSelectAndRebuild(mem_, preambleLongs_, lgNomLongs_, lgArrLongs_, curCount_); //rebuild
375380
curCount_ = mem_.getInt(RETAINED_ENTRIES_INT);
376381
thetaLong_ = mem_.getLong(THETA_LONG);

0 commit comments

Comments
 (0)