Merge pull request #449 from apache/fix_spotbugs

Some newly detected SpotBugs issues resolved.

Author: leerho

src/main/java/org/apache/datasketches/sampling/ReservoirItemsSketch.java

@@ -223,7 +223,7 @@ public static <T> ReservoirItemsSketch<T> heapify(final Memory srcMem,
     final boolean preLongsEqMin = (numPreLongs == Family.RESERVOIR.getMinPreLongs());
     final boolean preLongsEqMax = (numPreLongs == Family.RESERVOIR.getMaxPreLongs());
 
-    if (!preLongsEqMin & !preLongsEqMax) {
+    if (!preLongsEqMin && !preLongsEqMax) {
       throw new SketchesArgumentException(
               "Possible corruption: Non-empty sketch with only "
                       + Family.RESERVOIR.getMinPreLongs() + " preLong(s)");

src/main/java/org/apache/datasketches/sampling/ReservoirItemsUnion.java

@@ -104,7 +104,7 @@ public static <T> ReservoirItemsUnion<T> heapify(final Memory srcMem,
     final boolean preLongsEqMin = (numPreLongs == Family.RESERVOIR_UNION.getMinPreLongs());
     final boolean preLongsEqMax = (numPreLongs == Family.RESERVOIR_UNION.getMaxPreLongs());
 
-    if (!preLongsEqMin & !preLongsEqMax) {
+    if (!preLongsEqMin && !preLongsEqMax) {
       throw new SketchesArgumentException("Possible corruption: Non-empty union with only "
           + Family.RESERVOIR_UNION.getMinPreLongs() + "preLongs");
     }

src/main/java/org/apache/datasketches/sampling/ReservoirLongsSketch.java

@@ -204,7 +204,7 @@ public static ReservoirLongsSketch heapify(final Memory srcMem) {
     final boolean preLongsEqMin = (numPreLongs == Family.RESERVOIR.getMinPreLongs());
     final boolean preLongsEqMax = (numPreLongs == Family.RESERVOIR.getMaxPreLongs());
 
-    if (!preLongsEqMin & !preLongsEqMax) {
+    if (!preLongsEqMin && !preLongsEqMax) {
       throw new SketchesArgumentException("Possible corruption: Non-empty sketch with only "
           + Family.RESERVOIR.getMinPreLongs() + "preLongs");
     }

src/main/java/org/apache/datasketches/sampling/ReservoirLongsUnion.java

@@ -95,7 +95,7 @@ public static ReservoirLongsUnion heapify(final Memory srcMem) {
     final boolean preLongsEqMin = (numPreLongs == Family.RESERVOIR_UNION.getMinPreLongs());
     final boolean preLongsEqMax = (numPreLongs == Family.RESERVOIR_UNION.getMaxPreLongs());
 
-    if (!preLongsEqMin & !preLongsEqMax) {
+    if (!preLongsEqMin && !preLongsEqMax) {
       throw new SketchesArgumentException("Possible corruption: Non-empty union with only "
           + Family.RESERVOIR_UNION.getMinPreLongs() + "preLongs");
     }

src/main/java/org/apache/datasketches/theta/CompactOperations.java

@@ -123,7 +123,6 @@ static CompactSketch memoryToCompact(
     final int srcPreLongs = extractPreLongs(srcMem);
     final int srcSerVer = extractSerVer(srcMem); //not used
     final int srcFamId = extractFamilyID(srcMem);
-    final Family srcFamily = Family.idToFamily(srcFamId);
     final int srcLgArrLongs = extractLgArrLongs(srcMem);
     final int srcFlags = extractFlags(srcMem);
     final short srcSeedHash = (short) extractSeedHash(srcMem);